Skip to content
Snippets Groups Projects

change the id of UPHits in detector.xml

Merged Yanru Li requested to merge run5_UP_bit into master
All threads resolved!

By changing the id of UPHits in detector.xml, the memory space reserved for the modules has been reduced from 5 bits to 4 bits

Validated by

  • Core Software
  • RTA
  • Simulation
Edited by Yanru Li

Merge request reports

Merge request pipeline #9900527 passed

Merge request pipeline passed for 561de4f5

Approval is optional

Merged by Menglin XuMenglin Xu 1 month ago (Jan 16, 2025 10:19am UTC)

Merge details

  • Changes merged into master with 401fb897 (commits were squashed).
  • Deleted the source branch.

Pipeline #9900860 passed

Pipeline passed for 401fb897 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Yanru Li added 26 commits

    added 26 commits

    Compare with previous version

  • Menglin Xu resolved all threads

    resolved all threads

  • Menglin Xu marked this merge request as ready

    marked this merge request as ready

  • **** added 1 commit

    added 1 commit

    Compare with previous version

  • merged

  • Menglin Xu mentioned in commit 401fb897

    mentioned in commit 401fb897

    • Resolved by Menglin Xu

      We can make a follow up MR that adds back a volumeID.

      thanks! hope UP group can also follow that @yanru

      For future changes, can we build changes in Detector against what is in the run5 slot?

      sure, I will do that, sorry for this time

      Edited by Menglin Xu
  • Menglin Xu resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading