change the id of UPHits in detector.xml
By changing the id of UPHits in detector.xml, the memory space reserved for the modules has been reduced from 5 bits to 4 bits
Validated by
-
Core Software -
RTA -
Simulation
Merge request reports
Activity
- Resolved by Menglin Xu
/ci-test --model lhcb-sim11
added ci-test-triggered label
- [2024-10-16 09:44] Validation started with lhcb-sim11-mr#125
- [2024-11-21 18:48] Validation started with lhcb-sim11-mr#163
- [2024-11-26 08:06] Validation started with lhcb-sim11-mr#168
- [2025-01-09 12:17] Validation started with lhcb-sim11-mr#198
- [2025-01-15 14:15] Validation started with lhcb-master-mr#12241
Edited by Software for LHCbadded Upgrade2 label
added UP label
- Resolved by Menglin Xu
any updates?
added 26 commits
-
16914fcb...6ea53e92 - 24 commits from branch
master
- 1ab54637 - change the id of UPHits in detector.xml
- 0c69eeb5 - Deleted UPVolumeID.h
-
16914fcb...6ea53e92 - 24 commits from branch
- Resolved by Menglin Xu
/ci-test --model lhcb-sim11
- Resolved by Menglin Xu
/ci-test --model lhcb-sim11
- Resolved by Menglin Xu
/ci-test --model lhcb-sim11
- Resolved by Menglin Xu
/ci-test
- Resolved by Menglin Xu
- Resolved by Menglin Xu
Please rebase this MR, then I think we can merge it (I will take care of updating the reference). Also, pin @gcorti to inform her that you have changed the UP baseline geometry design.
Edited by Menglin Xu
added 26 commits
-
b0ccd067...5656dcc3 - 23 commits from branch
master
- ea20c97c - change the id of UPHits in detector.xml
- fc02224d - Deleted UPVolumeID.h
- c4a40b24 - change module id in UP_geo.cpp
Toggle commit list-
b0ccd067...5656dcc3 - 23 commits from branch
added update-working-checksum label
removed update-working-checksum label
mentioned in commit 401fb897
- Resolved by Menglin Xu
Sorry, why did you delete the UPVolumeID ? This causes Rec [run5] to no longer build
- Resolved by Menglin Xu
We can make a follow up MR that adds back a volumeID.
thanks! hope UP group can also follow that @yanru
For future changes, can we build changes in Detector against what is in the run5 slot?
sure, I will do that, sorry for this time
Edited by Menglin Xu