VPChannelID setters return reference to *this
add back returning reference to *this in VPChannelID
setters, and qualify them as constexpr
. This reverts the spurious removal in !645 (merged).
Validated by
-
Core Software -
RTA -
Simulation
Edited by Gerhard Raven
Merge request reports
Activity
Filter activity
mentioned in merge request !645 (merged)
added VP modernisation labels
- Resolved by Menglin Xu
/ci-test
- Resolved by Menglin Xu
/ci-test --model lhcb-sim11
changed milestone to %Digi17b/2024.12
added ci-test-triggered label
- [2024-12-02 12:48] Validation started with lhcb-master-mr#11986
- [2024-12-02 12:48] Validation started with lhcb-sim11-mr#179
- [2024-12-03 18:28] Validation started with lhcb-master-mr#11999
- [2024-12-04 18:10] Validation started with lhcb-sim11-mr#185
- [2024-12-05 13:00] Validation started with lhcb-master-mr#12018
- [2024-12-06 10:40] Validation started with lhcb-master-mr#12027
Edited by Software for LHCb- Resolved by Menglin Xu
/ci-test
This looks ok to me. It restores the returns to the setter functions and makes them all
constexpr
, which they weren't before (apart from the templatedset
function, which is restored to beingconstexpr
). So as long as the integration tests look ok (and I see no reason why they wouldn't be) I think it's fine. @hcroft do you have any comments?- Resolved by Menglin Xu
/ci-test --model lhcb-sim11
- Resolved by Menglin Xu
/ci-test
Please register or sign in to reply