[HCal] Fix missing units
All threads resolved!
All threads resolved!
I built a local version of GitCondDB, DD4hep and Detector and git a crash when visualizing the whole detector. This turned out to be because I had not build DD4hep with GEANT units and a unit was missing in the HCal geometry causing a wrong z ordering in a polycone.
For the LHCb builds this has no effect, but it's more correct.
Validated by
-
Core Software -
RTA -
Simulation
Merge request reports
Activity
- Resolved by Menglin Xu
/ci-test
assigned to @mexu
- Resolved by Menglin Xu
/ci-test --model lhcb-sim11
added ci-test-triggered label
- [2024-12-03 11:50] Validation started with lhcb-master-mr#11997
- [2024-12-03 11:53] Validation started with lhcb-sim11-mr#181
Edited by Software for LHCbrequested review from @dmanuzzi
- Resolved by Daniele Manuzzi
Hi @dmanuzzi, we think this MR is ready to go, could you please double check the units added here
mentioned in commit 4b2e4c77
mentioned in issue Moore#896 (closed)
mentioned in merge request !624 (merged)
Please register or sign in to reply