Add access to pixelID in VPChannelID to fix associators
All threads resolved!
All threads resolved!
The mchit to VPChannelID linker tables use the full information, including fraction in x and y of VPChannelID. Which means it breaks the code to check the MCHit efficiency, so to restore that the static pixelID function added to VPChannelID strips the bit to just the pixel address (sensor, chip, row, column) from a full integer. This is required to use the MR Lbcom!763 (merged).
Validated by
-
Core Software -
RTA -
Simulation
Edited by Sebastien Ponce
Merge request reports
Activity
added VP label
requested review from @tlatham
mentioned in merge request Lbcom!763 (merged)
- [2024-12-30 14:58] Validation started with lhcb-master-mr#12150
- [2024-12-30 14:59] Validation started with lhcb-sim11-mr#195
- [2025-01-10 08:43] Validation started with lhcb-master-mr#12190
- [2025-01-10 08:43] Validation started with lhcb-sim11-mr#202
- [2025-01-13 09:42] Validation started with lhcb-sim11-mr#204
- [2025-01-14 08:27] Validation started with lhcb-master-mr#12219
- [2025-01-17 09:40] Validation started with lhcb-sim11-mr#208
Edited by Software for LHCb- Resolved by Sebastien Ponce
tests look good, any reason to not have merged this and Lbcom!763 (merged) ?
- Resolved by Sebastien Ponce
All tests (master and sim11) look good to me. @gcorti may you tick the Simulation box if you're happy to merge ?
added 11 commits
-
d109cfc8...401fb897 - 7 commits from branch
master
- eb820a49 - Set only useful bits in VPChannelID, but sensor = 255 when unintialised and...
- b4e22939 - Fixed formatting
- cd37db8e - Added static routine to get pixelID to VPChannelID
- bde564b9 - Fixed formatting
Toggle commit list-
d109cfc8...401fb897 - 7 commits from branch
mentioned in commit 44e00de8
mentioned in issue #74
Please register or sign in to reply