Draft: RICH : Updating default values of gas pressure and temperature
This MR enables to update and use the default values of gas pressure and temperature in RICH1 and RICH2. The values are listed in the file RichRun3PropertySpecParam.xml. The new values are same as those used as default in the lhcb-conditions-database in the sim10/run3-ideal branch.
In processing real data, these values are set as the default and any variations of these are monitored in the online. These default values facilitate to run the software chain Gauss-Boole-Moore. The details of this can be found the recent discussion in #73
At present a copy of this file exists in ../Materials/trunk and in ../Materials/2024-v00.00 areas. However, only the values in the file in ../Materials/trunk area are updated in this MR.
A copy of this file also existed in the ../Rich/xxxx/Rich1/DetElem areas, but their usage seems to be commented out, since a few months ago. Hence the copies in this file in these Rich areas are removed as part of cleanup.
Example of RICH resolution plots obtained after running Gauss-Boole-Moore with this update from the trunk area, are attached to this MR for reference.
Validated by
-
Core Software -
RTA -
Simulation
Merge request reports
Activity
assigned to @sponce
Attaching the two plots mentioned above, as reference.Reco_R1_Pgun_res_allPhot.pdf Rich2-TP-ckvres.pdf
- Resolved by Menglin Xu
One very general comment: could you please clean up the comment lines? like
// refTemperature = detail::dd4hep_param<double>( "C4F10ReferenceTemperature" );
And
<!-- <constant name="Rich1NitrogenTemperature" value="293.*kelvin" /> Changed to the value above on Feb13-2025 to match default in CondDB for C4F10 -->
Edited by Menglin Xu
And I this here you would like to also introduce a new vesrion of the Materials, like what you/Christopher did for Rich in !667 (merged)
added RICH label
Actually, I also want to recommend preparing an INFO file to document the changes in the new version, similar to what has been done for VP, see https://gitlab.cern.ch/lhcb/Detector/-/blob/f15bfac2f72cdf1723d224230dd5d59b9c327a14/compact/components/VP/2024-v01.00/INFO.md. This will help track changes more effectively in the future.
But I would like to clarify that this INFO file is just a temporary solution for version documentation. Ultimately, we aim to use standardized files and tools for this purpose, such as the MR !612 I previously prepared. However, until the final format is confirmed with other teams, the INFO file remains a good idea. Transferring the information to the final chosen format should be straightforward. (I can do that)
added 1 commit
- b73d56a1 - Minor update set the before-rich1-geom-update-26052022 folder to keep its...
- Resolved by Menglin Xu
Thanks @seaso , I would really appreciate it if you can create a new version for Material, like
2024-v00.01
(just for simulation @gcorti please correct me if Simulation does not require this) and maybe also one for 2025,2025-v00.00
. And it would also be helpful to prepare an INFO file documenting the changes in the new versions, similar to what has been done for VP, see https://gitlab.cern.ch/lhcb/Detector/-/blob/f15bfac2f72cdf1723d224230dd5d59b9c327a14/compact/components/VP/2024-v01.00/INFO.md. This will help track changes more effectively in the future as I commented above !682 (comment 9081895)The Materials already has ‘version labels’. The current update is done only in ‘Materials/trunk’ area with the aim of using it in simulations. (The reconstruction does not ‘use’ this.).
I was not sure if we need to create new ‘fixed versions’ just for this; but if the ‘Simulation group’ needs to create new ‘fixed versions’ for many items, including this, please feel free to do so. The documentation is already in #73.
If a material is changed to be used in a simulation production it should have a new version. There will not be any production using
trunk
, as it would not be guaranteed not be modified in the future. On the other hand I agree with you that we should do that at the same time we make a new complete version of the LHCb geometry. Since we are doing so for both2024-v00.01
and2025-v00.00
please do so. And add anINFO.md
file with a very short description, something like:Change of default properties for RICH gas to....
Similarly please make a short
INFO.md
file to explain what change were made in the RICH, 2-3 lines are more then sufficient and you can refer to #73, that otherwise will be impossible to find in the future.
@seaso Can you please post here path to some XDIGI/XSIM files (on EOS) that you generated using DD4HEP Gauss with the fixes here ? In order to review this I need to setup some tests downstream in Rec/Panoptes that runs over DD4HEP MC with these fixes to validate that these changes indeed improve things.
Can you also please clearly state which dd4hep compact geom and data base tags you used to generate the data.
Edited by Christopher Rob Jones@seaso ping, can you please point me at some test data generated with this fix ?
@seaso Just to try and be abundantly clear here, can you please make available a small (say 1000 events) sample of DD4HEP simulated events with the fix here ?
Edited by Christopher Rob Jones
requested review from @zexu
added 25 commits
-
b73d56a1...959a4a3b - 20 commits from branch
master
- f028d625 - Updates for gas pressure temperature default values and cleanup of unused files
- 79ca07e7 - Fixed formatting
- 72ad4ac5 - Keeping P,T values in Materials/2024-v00.00 area unchanged
- 91e20ce4 - Minor update set the before-rich1-geom-update-26052022 folder to keep its...
- 07005f9f - Adding documentation file doc/RICH_INFO.md
Toggle commit list-
b73d56a1...959a4a3b - 20 commits from branch
- Resolved by Menglin Xu