cleanup unnecessary function in c++

This MR is only for cleaning up some unnecessary parts in the C++ code without changing any geometry.

Cleanup:

• remove buildVolumes from build_groups or build_detector

  The VolumeBuilder::load function already calls VolumeBuilder::buildVolumes, so the explicit later call is redundant.

• remove placeDaughters

  Besides Infranstruce, for sub-detectors, all position, rotation, and other parameters of the daughter volumes are dynamically calculated (rather than statically defined in XML). In this case, we must manually call placeVolume() to place the daughter volumes, as XML cannot predefine the computed values. Then placeDaughters() is redundant.

---

Validated by

• Core Software
• RTA
• Simulation

added cleanup label

requested review from @tlatham

assigned to @mexu

added 1 commit

• d28f9688 - can not remove buildVolumes for MP

Compare with previous version

requested review from @sponce

requested review from @bcouturi

/ci-test

added ci-test-triggered label

• [2025-03-04 13:13] Validation started with lhcb-master-mr#12758
• [2025-03-10 15:04] Validation started with lhcb-master-mr#12824
• [2025-03-11 13:28] Validation started with lhcb-sim11-mr#303
• [2025-03-11 15:43] Validation started with lhcb-master-mr#12845

changed the description

added 1 commit

• d3a55940 - remove placeDaughters from VP

Compare with previous version

Thanks for this clean-up @mexu

In addition to the couple of inline comments, I see that HCAL_geo.cpp has not been modified. If the suggestion for FT/MP works out ok, could we try that for HCAL as well?

resolved all threads

added 10 commits

• d3a55940...839cf2a0 - 6 commits from branch master
• 26f4a122 - remove buildVolumes from ECAl MP muon Rich UP UT and VP
• f62c7aa8 - remove placeDaughters
• 7297dadc - can not remove buildVolumes for MP
• 38a7216b - remove placeDaughters from VP

Compare with previous version

/ci-test

requested review from @jonrob

requested review from @gcorti

changed the description