Fix VPChannelID initialisation

This change only sets the "sensor" bits of VPChannelID when initialising with no value. The old version also set all of the bits and due to a mistake in !645 (merged) this means the pointToChannel function in VPSensor returned a VPChannelID where the orx & ory values were always set (fraction of channel in x and y). This was causing problems for the VP associators, and meant the linker tables were not correct. This fixes the issue raised in Lbcom!812 (merged)

Without this fix there will be issues with both linkers and VPClusters being offset by a fraction of a pixel using Retina Clusters.

---

Validated by

• Core Software
• RTA
• Simulation

added VP label

assigned to @tlatham

mentioned in merge request Lbcom!812 (merged)

approved this merge request

• [2025-03-25 17:44] Validation started with lhcb-master-mr#13081
• [2025-03-26 11:28] Validation started with lhcb-sim11-mr#346
• [2025-03-26 11:30] Validation started with lhcb-master-mr#13088
• [2025-03-26 13:52] Validation started with lhcb-sim11-mr#348
• [2025-03-26 13:53] Validation started with lhcb-sim11-mr#349

marked this merge request as ready

@msaur @tlatham The output from this test also looks OK for Boole, with BuildMCTracks working properly (in DetDesc, the tests are still blocked in DD4HEP).

mentioned in commit Boole@90847093

mentioned in merge request Boole!686 (merged)

@mexu @gcorti @sponce Are this fine with you? Tested at Lbcom!812 (merged) (Lbcom!812 (comment 9274024)).

added 1 commit

• 6346bde8 - Update clang-format and switch to Ruff for Python

Compare with previous version

reset approvals from @tlatham by pushing to the branch

added 1 commit

• 94420476 - Fix VPChannelID initialisation

Compare with previous version

added 3 commits

• 94420476...13c4bdc8 - 2 commits from branch master
• 1e377172 - Fix VPChannelID initialisation

Compare with previous version

Had to do a rebase as the new formatting changed the line too and it could not be fast forwarded.

/ci-test --model lhcb-sim11 Lbcom!812 (merged)

added ci-test-triggered label

marked the checklist item Simulation as completed

mentioned in commit MooreOnline@45399ff5

mentioned in merge request MooreOnline!570 (closed)