Merge upstream master into cmake-modernisation branch

There were a few textual and semantic conflicts. Most notably:

• ignored the changes from gaudi/Gaudi!1103 (merged) as it wasn't obvious how they translate to new cmake
• ignored the changes related to Python 3 builds (GitLab CI, support for +py3 compiler suffix in BINARY_TAG)
• made sure GAUDI_VERSION.h can be included as with old cmake.
• fixed a missing and some misplaced test executable declaration in GaudiKernel/CMakeLists.txt
• added a script and a CI job to check for unused sources (the new cmake requires explicit listing of each compilation unit)
• fix lookup for executables ending with .exe in tests (before tests picked up wrong executables from LCG views)

https://gitlab.cern.ch/lhcb/Gaudi/-/tree/cmake-modernisation is currently identical to https://gitlab.cern.ch/clemenci/Gaudi/-/tree/cmake-modernisation . This MR is supposed to merge all the recent developments from master and will hopefully get us working nightly slots again (together with changing the source branch in lhcb-core/LHCbNightlyConf!434 (merged)).

@sponce I'm not super familiar with CMake, so if you'd like to have another look that's appreciated. I rebased upgrade-hackathon-setup!39 (merged) and that seems to work as well. Now on to the dd4hep branch there...

assigned to @rmatev and unassigned @sponce

added 3 commits

• 36e8c0fd - Merge remote-tracking branch 'origin/master' into cmake-modernisation
• f3a3705e - Fix test declaration in GaudiKernel CMakeLists
• a7dbba61 - Add a script and CI job checking for unused sources

Compare with previous version

added 4 commits

• 47c4811d - Merge remote-tracking branch 'origin/master' into cmake-modernisation
• 560fbfb1 - Add `${CMAKE_BINARY_DIR}/include` to include dirs
• 9fd27845 - Fix test declaration in GaudiKernel CMakeLists
• b74fc53c - Add a script and CI job checking for unused sources

Compare with previous version

changed the description

added 1 commit

• bf6537bf - Add a script and CI job checking for unused sources

Compare with previous version

changed the description

added lhcb-new-cmake label

added 3 commits

• 2ac16cfa - Workaround for IJobOptionsSvc deprecation warning in tests
• 76eeb0b9 - Workaround for IJobOptionsSvc deprecation warning in tests
• 792c7155 - Merge remote-tracking branch 'origin/master' into cmake-modernisation-merge-Aug6

Compare with previous version

• [2020-08-07 00:11] Validation started with lhcb-new-cmake#153
• [2020-08-08 00:11] Validation started with lhcb-new-cmake#154

Sorry I'm a bit lost here. Why do you "Merge upstream master into cmake-modernisation branch" ? I would rather rebase cmake-modernisation onto upstream master. Wouldn't that be more logical ?

changed the description

https://lhcb-nightlies.web.cern.ch/nightly/lhcb-new-cmake/build/153/ looks much better than yesterday, and I'd say we can either merge this straight away or give it a go in lhcb-gaussion and lhcb-dd4hep (by labeling wiht all-slots )

Indeed ! Let's merge I would say. This is a side branch that only few people use and we can undo it in the worst case. Do you want me to click the button ?

okay let's go!

except the merge button is disabled because of failing tests.... Do you understand the 2 failures ?

no :( I mentioned them in the description. I'm tempted to merge manually or disable this feature (I don't have the karma, but it's at https://gitlab.cern.ch/lhcb/Gaudi/edit, under "Merge requests").

I restarted the pipeline on the cmake-modernisation branch to see if there all is green, let's see

The problem is indeed new as the old pipeline didn't have it: https://gitlab.cern.ch/lhcb/Gaudi/-/pipelines/1850180 I'll investigate

I fixed that with c1ea57b7 and after a few job restarts (due to some weird non-reproducible errors error while loading shared libraries ... file too short) the pipeline is now green.

Well spotted !

resolved all threads

resolved all threads

added 1 commit

• c1ea57b7 - Fix lookup for executables ending with .exe

Compare with previous version

changed the description

resolved all threads

merged

mentioned in commit 829a1a41