Skip to content

Fix trivial compilation warnings from gcc8

Michal Kreps requested to merge gcc8Warnings into master

Looked through all warnings we had in nightlies in lhcb-head slot and cleaned up as much as possible. There are 4 types of warnings remaining:

  • Warning coming from Gaudi include file
  • Use of tmpnam to create temporary file. It happens in LbPythia and EvtGen. As we want to remove pythia6 anyhow I did not bother to think about it. For EvtGen, I have a plan how to handle it but will need small development in EvtGen itself which I prefer to do once we finish few things in the general repository and we switch to use that inside Gauss.
  • Warnings about paddings in FORTRAN common blocks, which basically wants reordering variables to start with doubles, floats and finish with ints. In some cases, we cannot trivially do it because common blocks are from external libraries while in other cases I was not confident enough to decide whether the common block is really local to the package and that I would manage to spot if not.
  • Some half nasty GOTO jumps in SuperChic2 which we could possibly sort out but would result in non-trivial change, so left it there for now.
Edited by Michal Kreps

Merge request reports