Skip to content
Snippets Groups Projects

[Futurev4] fix failing tests

Merged Michal Mazurek requested to merge Futurev3_fix_failing_tests into Futurev4
All threads resolved!
  • Test 1: GaussSys.gausssys Here, I had to change the test so that it accepts the minimum working configuration coming from Gaussino.
  • Test 2: LoKiGen.jira_461 ROOTIO from HepMC3 caused namespace collision with HepMC. It'll be now commented out in Gaussino as there is no need for it yet.
  • Test 3: LoKiGen.lokigen0 Same problem as above + it looks like LoKi has some problems with dereferencing HepMC.GenParticle(). For example, this GP(HepMC.GenParticle()) gives
static double LoKi::Dicts::FunCalls<HepMC3::GenParticle>::__call__(LoKi::Functor<shared_ptr<const HepMC3::GenParticle>,double>& fun, const shared_ptr<const HepMC3::GenParticle>& o) =>
    could not convert argument 2
  • Test 4: GaussTracker.shortened_sensdet_name This test, in its current shape, won't work because the expected debug debug() << "Sens det shortened name " << name() << " -> " << detname << endmsg; has been moved to the construct() in GiGaMTG4SensDetFactory. I wonder, in fact, whether this test is going to be useful... update: This is a very specific configuration in order to trigger a debug message with a shortened name of the sensitive detector. In order to do so, in Gauss-on-Gaussino it will only be triggered by running construct() on the GiGaSensDetTracker.

needs Gaussino/Gaussino!18 (merged) @gcorti @dmuller

Edited by Michal Mazurek

Merge request reports

Pipeline #2873120 passed

Pipeline passed for 9ec0fe31 on Futurev3_fix_failing_tests

Merged by Gloria CortiGloria Corti 3 years ago (Sep 17, 2021 7:34am UTC)

Merge details

  • Changes merged into Futurev4 with 0f880168.
  • Deleted the source branch.

Pipeline #3026716 passed

Pipeline passed for 0f880168 on Futurev4

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading