Resolve "LbMadGraph configurable"

Closes #30 (closed)

This should either be merged into LHCBGAUSS-1374.Madgraph or applied after merging !573 (closed).

mentioned in merge request !573 (closed)

changed target branch from LHCBGAUSS-1374.Madgraph to v55r0-release

added 1 deleted label

In order to be taken up in the nightly slot need to target branch there and have according label ~"lhcb-gauss-gen-dev"

added 1 deleted label and removed 1 deleted label

changed target branch from v55r0-release to v54r5-release

added 1 commit

• 2426c322 - init mg configuration

Compare with previous version

@adavis could you help how to define entry condition in the Gauss/Configuration.py part? Sth similar to this:

# PG Primary Vertex configuration
if 'PGUN' in self.getProp('Production'):
   from SimComponents.ConfigurePGPrimaryVertex import ConfigurePGPrimaryVertex as cfg
   ....

this is from https://gitlab.cern.ch/lhcb/Gauss/-/blob/master/Sim/Gauss/python/Gauss/Configuration.py#L2996
How it would look like in the case of MadgrapProduction? Should sth like below work?

if 'Madgraph' in self.getProp('Production'):
   from LbMadgraph import ConfigureMadgraph as cfmg
   ...

• [2021-04-13 00:13] Validation started with lhcb-gauss-gen2-dev#279
• [2021-04-14 00:17] Validation started with lhcb-gauss-gen2-dev#280
• [2021-04-15 00:19] Validation started with lhcb-gauss-gen2-dev#281
• [2021-04-16 00:13] Validation started with lhcb-gauss-gen2-dev#282
• [2021-04-17 00:19] Validation started with lhcb-gauss-gen2-dev#283
• [2021-04-18 00:05] Validation started with lhcb-gauss-gen2-dev#284
• [2021-04-19 00:09] Validation started with lhcb-gauss-gen2-dev#285
• [2021-04-20 00:12] Validation started with lhcb-gauss-gen2-dev#286
• [2021-04-21 00:19] Validation started with lhcb-gauss-gen2-dev#287
• [2021-04-22 00:14] Validation started with lhcb-gauss-gen2-dev#288
• [2021-04-23 00:23] Validation started with lhcb-gauss-gen2-dev#289

I've put all suggestions in the code, however got such an issue when trying to push...

git lb-push Gauss 30-lbmadgraph-configurable
fatal: Dirty index: cannot apply patches (dirty: Gen/LbMadgraph/options/MadgraphPythia8.py Gen/LbMadgraph/python/LbMadgraph/ConfigureMadgraph.py Gen/LbMadgraph/src/component/MadgraphProduction.cpp Gen/LbMadgraph/src/component/MadgraphProduction.h)
ERROR:root:failed to apply commit 54fe6343e3b06bcd244625f64c9264c772afc8e2

Any hints? Git doesn't suggest anything as normally do :/

added 3 commits

• 56002e83 - refactor LbMadgraph python config
• 01bfc91c - extend Gauss configuration
• 86f9141d - refactor LbMadgraph src as for new configurable scheme

Compare with previous version

closed

reopened

changed the description

Note that this is TEMPORARILY targeting v54r5-release to allow separate development and checking in lhcb-gauss-gen2-dev but it will need to be moved to targeting master together with !573 (closed)

• [2021-04-24 00:25] Validation started with lhcb-gauss-gen2-dev#290
• [2021-04-25 00:03] Validation started with lhcb-gauss-gen2-dev#291
• [2021-04-26 00:08] Validation started with lhcb-gauss-gen2-dev#292
• [2021-04-27 00:11] Validation started with lhcb-gauss-gen2-dev#293
• [2021-04-28 00:08] Validation started with lhcb-gauss-gen2-dev#294
• [2021-04-29 00:15] Validation started with lhcb-gauss-gen2-dev#295
• [2021-04-30 00:18] Validation started with lhcb-gauss-gen2-dev#296
• [2021-05-01 00:18] Validation started with lhcb-gauss-gen2-dev#297
• [2021-05-02 00:05] Validation started with lhcb-gauss-gen2-dev#298
• [2021-05-03 00:04] Validation started with lhcb-gauss-gen2-dev#299
• [2021-05-04 00:04] Validation started with lhcb-gauss-gen2-dev#300
• [2021-05-05 00:07] Validation started with lhcb-gauss-gen2-dev#301
• [2021-05-06 00:07] Validation started with lhcb-gauss-gen2-dev#302
• [2021-05-07 00:09] Validation started with lhcb-gauss-gen2-dev#303
• [2021-05-08 00:09] Validation started with lhcb-gauss-gen2-dev#304
• [2021-05-09 00:07] Validation started with lhcb-gauss-gen2-dev#305
• [2021-05-10 00:03] Validation started with lhcb-gauss-gen2-dev#306
• [2021-05-11 00:07] Validation started with lhcb-gauss-gen2-dev#307
• [2021-05-12 00:10] Validation started with lhcb-gauss-gen2-dev#308
• [2021-05-13 00:12] Validation started with lhcb-gauss-gen2-dev#309
• [2021-05-14 01:45] Validation started with lhcb-gauss-gen2-dev#310
• [2021-05-17 00:08] Validation started with lhcb-gauss-gen2-dev#313

added 1 commit

• 654f886d - new config flow defined for Gauss.BeamBeam

Compare with previous version