Always clone associated CaloDigit objects for PersistReco

Depends on Phys!233 (merged).

Also included a change to the TES location collection heuristic to ignore services. We don't expect any services to define properties with TES locations that we need to have in the HltANNSvc, and there are properties that we definitely don't want to have (like the Input property of the EventSelector service).

A TODO for myself: we'll need to make sure that the cloners in Tesla are similarly configured. See DaVinci!139 (merged).

• [2018-01-11 00:11] Validation started with lhcb-2018-patches#82
• [2018-01-12 00:09] Validation started with lhcb-2018-patches#83
• [2018-01-13 00:11] Validation started with lhcb-2018-patches#84
• [2018-01-14 00:11] Validation started with lhcb-2018-patches#85
• [2018-01-15 00:11] Validation started with lhcb-2018-patches#86
• [2018-01-16 00:10] Validation started with lhcb-2018-patches#87
• [2018-01-17 00:14] Validation started with lhcb-2018-patches#88
• [2018-01-18 00:11] Validation started with lhcb-2018-patches#89
• [2018-01-19 00:12] Validation started with lhcb-2018-patches#90
• [2018-01-20 00:12] Validation started with lhcb-2018-patches#91
• [2018-01-21 00:13] Validation started with lhcb-2018-patches#92
• [2018-01-22 00:15] Validation started with lhcb-2018-patches#93
• [2018-01-23 00:14] Validation started with lhcb-2018-patches#94
• [2018-01-24 00:13] Validation started with lhcb-2018-patches#95
• [2018-01-25 00:12] Validation started with lhcb-2018-patches#96

mentioned in merge request DaVinci!139 (merged)

added check diff ~1529 turbo labels

added 1 commit

• 26cb20aa - Always use fully-qualified tool names, and inherit props from existing tool instance.

Compare with previous version

Cleaned up based on Rosen's comment on the DaVinci MR, and fixed the problem that broke the nightly.

There appears to be something more to it (from here):

29	Traceback (most recent call last):
30	  File "/build/jenkins-build/workspace/nightly-builds/build/build/GAUDI/GAUDI_v29-patches/InstallArea/x86_64-slc6-gcc62-opt/scripts/gaudirun.py", line 457, in <module>
31	    applyConfigurableUsers()
32	  File "/build/jenkins-build/workspace/nightly-builds/build/build/GAUDI/GAUDI_v29-patches/InstallArea/x86_64-slc6-gcc62-opt/python/GaudiKernel/Configurable.py", line 1552, in applyConfigurableUsers_old
33	    c.__apply_configuration__()
34	  File "/build/jenkins-build/workspace/nightly-builds/build/build/HLT/HLT_2018-patches/InstallArea/x86_64-slc6-gcc62-opt/python/HltConf/HltAfterburner.py", line 555, in __apply_configuration__
35	    AfterburnerSeq.Members += [self._persistRecoSeq()]
36	  File "/build/jenkins-build/workspace/nightly-builds/build/build/HLT/HLT_2018-patches/InstallArea/x86_64-slc6-gcc62-opt/python/HltConf/HltAfterburner.py", line 383, in _persistRecoSeq
37	    self._copyTurboOutputsSeq(lineOutputs, outputPrefix),
38	  File "/build/jenkins-build/workspace/nightly-builds/build/build/HLT/HLT_2018-patches/InstallArea/x86_64-slc6-gcc62-opt/python/HltConf/HltAfterburner.py", line 438, in _copyTurboOutputsSeq
39	    container_cloner.TurboPPICloneCaloHypo = container_cloner.addTool(chc_pp).getFulName()
40	  File "/build/jenkins-build/workspace/nightly-builds/build/build/GAUDI/GAUDI_v29-patches/InstallArea/x86_64-slc6-gcc62-opt/python/GaudiKernel/Configurable.py", line 424, in __getattr__
41	    "'%s' object has no attribute '%s'" % (self.__class__, attr))
42	AttributeError: '<class 'MicroDSTTools.MicroDSTToolsConf.CaloHypoCloner'>' object has no attribute 'getFulName'

Urgh, typo Sorry about that, I've pushed the fix.

added 1 commit

• b1a0d51d - Typo.

Compare with previous version

approved this merge request

merged

mentioned in commit 0e8c1fbb

removed check diff label

changed milestone to %v28r0