Merge 2018 into master

Ports !588 (merged), !586 (merged), !582 (merged), !581 (merged), !580 (merged), !577 (merged), !574 (merged), !578 (merged), !579 (merged), !571 (merged), !568 (merged), !567 (merged), !566 (merged), !565 (merged), !564 (merged), !544 (merged), !563 (merged), !562 (merged), !559 (merged), !553 (merged), !551 (merged), !552 (merged), !550 (merged), !547 (merged), !546 (merged), !528 (merged), !511 (merged), !512 (merged), !545 (merged), !543 (merged), !541 (merged), !537 (merged), !536 (merged), !534 (merged), !532 (merged), !530 (merged), !527 (merged), !525 (merged), !522 (merged), !519 (merged), !521 (merged), !513 (merged), !510 (merged), !509 (merged), !508 (merged), !498 (merged), !493 (merged), !506 (merged), !542 (merged), !504 (merged), !470 (merged), !500 (merged), !476 (merged), !478 (merged), !491 (merged), !503 (merged)

removed milestone

marked as a Work In Progress

This can go after the v30 release, or never...

PID cuts on pions and protons from the Xc have been tighten. PT on Xc and tau increased from 0 to 1 GeV.

added 82 commits

• f926d4fb...1ca7a57e - 17 commits from branch master
• 56fc001d - Remove prescale on Xic0 LTUNB line again.
• c865b7f6 - new X->gamma gamma lines
• 511971a1 - Merge branch 'SB-gammagamma' into '2018-patches'
• 937dfa8e - Add new displaced jet lines
• f9669269 - Merge branch 'IK_DisplacedJets' into '2018-patches'
• 63506368 - Merge branch 'malexand-rm-Xic0LTUNB-prescale' into '2018-patches'
• 8ab3a342 - Add a Phi->mumu Hlt2 line
• af735826 - Merge branch 'nkitzman_phi2mumu_Hlt2Line' into '2018-patches'
• 2ec2f8b1 - Prepare v28r2 release
• 60618b67 - Merge branch 'release-v28r2' into '2018-patches'
• b8546e33 - The actual changes
• b78a4766 - Remove the prescale of Hlt2CharmHadXic0ToPpKmKmPip_LTUNBTurbo
• 90ffa699 - tightening cuts to reduce rates (PIDK, PIDp, XcPT, tauPT)
• 6037a5a5 - Merge branch 'really-remove-Xic0LTUNB-prescale' into '2018-patches'
• 7ef36444 - Merge branch 'EleTrackEff2018p2' into '2018-patches'
• 57dbb622 - Merge branch 'romerov/tightXc3Pi/LBHLT-395' into '2018-patches'
• 55dbb452 - Accept only NoBias in HLT1 and HLT2 CharmXSec lines
• 2d8d54fb - Implement stripping/offline cuts for R(Xc) lines
• d368cf0f - Disable Hlt2Xc3PiXForTauD02K3pi lines
• beaff7ce - Add 1.5 GeV cut on the highest-PT Xc track
• 642f336d - Merge branch 'charmxsec-nobias' into '2018-patches'
• 7049657c - Merge branch 'tighten-xc3lines' into '2018-patches'
• d250c647 - Revert the ODIN NoBias requirement in Hlt2 CharmXSec lines
• 4334851b - Merge branch 'revert-hlt2-charmxsec' into '2018-patches'
• 5be229de - Add default monitoring range for Omega_c0
• 5657d5f8 - Add Turbo lines for Hc2HHHLam and Hc2HHpKS
• 65eac101 - Merge branch 'LBHLT-396-mamartin' into '2018-patches'
• 2439a19d - Add stripped vertex information for monitoring
• 69af5000 - Turn on creation of split vertices
• ca125b6e - Merge branch 'axu/AddOmegacMonitoringRange' into '2018-patches'
• 89eed020 - Merge branch 'StrippedVertices' into '2018-patches'
• b35fe4fb - Change TurboSP selection to OVERLAP instead of cone.
• c7dd4ccf - Merge branch 'ldufour-turobsp-for-trackeff-p2' into '2018-patches'
• 6519e0f3 - Prescale the Hlt1BeamGasHighRho line
• a6864531 - Merge branch 'fix-beamgashighrho' into '2018-patches'
• cbd2f83d - Prepare v28r2p1 release
• e18b27f2 - Merge branch 'release-v28r2p1' into '2018-patches'
• a633d2d3 - Modify the threshold setting of InclOmegac BDT filter
• 7f1a7ee7 - Use the v2 of look-up table
• 334e0657 - Tighten the BDT cut to 0.30
• 137c0938 - Merge branch 'axu/Modify-InclOmegac-BDT-Threshold' into '2018-patches'
• 25947072 - changed BDT working point for Hlt2CharmHadInclXicpToKmPpPipBDTTurbo line and…
• 450db66c - Merge branch 'mutraill/Modify-InclXicp-BDT-Threshold' into '2018-patches'
• 5b12d0cd - Add new Hlt1Line for LowMult Dimuon monitoring
• 1d35d96e - Add Hlt1LowMultDimuonMonitor line to active lines
• 3275f945 - Add routing bit 58 for Herschel monitoring
• 68ac37a7 - Add LowMultDiMuon invariant mass monitoring plot
• 7b3e28c8 - Merge branch 'johndan-NewHlt1LineHerschelMonitoring' into '2018-patches'
• e7a641e2 - Modify Hlt2HcetacPPmumuTurbo line to reduce the rate
• 6e7f1843 - Merge branch 'rcardinale/Hcetacppmumuturbo' into '2018-patches'
• 738b68bf - Reenable Hlt2Xc3PiXForTauD02K3pi R(Xc) lines
• a64b412a - Merge branch 'romerov/AddXc3PiD02K3piLine' into '2018-patches'
• ceba23f6 - Prepare v28r3 release
• f780a792 - Merge branch 'release-v28r3' into '2018-patches'
• 64f318fb - Capitalize muon in LowMultDiMuonMon
• 2adfb6e2 - Fix routing bit definition
• ba10ad97 - Merge branch 'fix-lowmultdimuonmon' into '2018-patches'
• 1d2ea115 - Fix inconsistent cuts in Hlt2Lines
• f12e820e - Add VanDerMeerScan_2018 settings
• 8380028a - Merge branch 'vdm-2018' into '2018-patches'
• ce731ed7 - Fix bug in Hlt1LowMultDiMuonMonitor
• ca3475fb - Merge branch 'fix-lowmultdimuonmon' into '2018-patches'
• 3dac8d87 - New jet lines for light gluino search
• 8bd86623 - Merge branch 'IK_Gluinos' into '2018-patches'
• b4694ea5 - Merge remote-tracking branch 'origin/2018-patches' into merge-2018-into-master

Compare with previous version

unmarked as a Work In Progress

changed the description

changed milestone to %v30r1

• [2018-08-07 00:16] Validation started with lhcb-lcg-dev4#609
• [2018-08-07 00:19] Validation started with lhcb-head#1942
• [2018-08-07 00:22] Validation started with lhcb-lcg-dev3#610
• [2018-08-07 00:27] Validation started with lhcb-tdr-test#245
• [2018-08-07 00:28] Validation started with lhcb-gaudi-head#1954
• [2018-08-07 13:22] Validation started with lhcb-tdr-test#246
• [2018-08-08 00:18] Validation started with lhcb-head#1943
• [2018-08-08 00:18] Validation started with lhcb-lcg-dev4#610
• [2018-08-08 00:22] Validation started with lhcb-tdr-test#247
• [2018-08-08 00:22] Validation started with lhcb-lcg-dev3#611
• [2018-08-08 00:23] Validation started with lhcb-gaudi-head#1955
• [2018-08-08 10:44] Validation started with lhcb-gaudi-merge#553
• [2018-08-08 12:33] Validation started with lhcb-tdr-test#248
• [2018-08-09 00:18] Validation started with lhcb-lcg-dev3#612
• [2018-08-09 00:21] Validation started with lhcb-lcg-dev4#611
• [2018-08-09 00:23] Validation started with lhcb-gaudi-head#1956
• [2018-08-09 00:25] Validation started with lhcb-head#1944
• [2018-08-09 00:27] Validation started with lhcb-tdr-test#249
• [2018-08-09 12:54] Validation started with lhcb-gaudi-merge#554
• [2018-08-10 00:20] Validation started with lhcb-lcg-dev4#612
• [2018-08-10 00:22] Validation started with lhcb-head#1945
• [2018-08-10 00:23] Validation started with lhcb-lcg-dev3#613
• [2018-08-10 00:25] Validation started with lhcb-tdr-test#250
• [2018-08-10 00:26] Validation started with lhcb-prerelease#1912
• [2018-08-10 00:36] Validation started with lhcb-gaudi-head#1957

assigned to @sneubert

@sneubert could you please approve and merge? This is a little big, but nightlies are ok-ish: https://lhcb-nightlies.cern.ch/logs/tests/nightly/lhcb-head/1943/x86_64-centos7-gcc7-opt/Moore/

You can wait till tomorrow if you prefer, when more tests should pass

mentioned in merge request !592 (closed)

This together with and !595 (merged) and Moore!142 (merged) makes the prerelease slot green https://lhcb-nightlies.cern.ch/nightly/lhcb-prerelease/build/1912/

It's only the genfsr test that fails an assertion in debug as the data is not appropriate I, guess. I will investigate this independently.

python: /workspace/build/REC/REC_v30r1/Muon/MuonID/src/lib/CommonMuonStation.cpp:94:
void CommonMuonStation::setHits(CommonMuonHits&&): Assertion `*id == std::end(m_hits)' failed.

approved this merge request

merged

mentioned in commit d52c324b