Convert assert to exception

Hlt/HLTScheduler/src/ControlFlowNode.cpp

@@ -130,8 +130,12 @@ findAllEdges( gsl::not_null<VNode const*> vnode, std::set<std::array<gsl::not_nu
   for ( auto const& edge : custom_edges ) append( edge[0], edge[1] );
 
   // check that nodes do not depend on themselves....
-  assert( std::none_of( nodePrerequisites.begin(), nodePrerequisites.end(),
-                        []( const auto& kv ) { return kv.second.find( kv.first ) != kv.second.end(); } ) );
+  auto it = std::find_if( nodePrerequisites.begin(), nodePrerequisites.end(),
+                          []( const auto& kv ) { return kv.second.find( kv.first ) != kv.second.end(); } );
+  if ( it != nodePrerequisites.end() ) {
+    throw GaudiException( "Node " + it->first->name() + " depends on itself.", __PRETTY_FUNCTION__,
+                          StatusCode::FAILURE );
+  }
 
   return nodePrerequisites;
 }
@@ -155,8 +159,12 @@ resolveDependencies( std::set<gsl::not_null<VNode*>>&
                      std::map<gsl::not_null<VNode*>, std::set<gsl::not_null<VNode*>>> const& nodePrerequisites ) {
 
   // check that nodes do not depend on themselves....
-  assert( std::none_of( nodePrerequisites.begin(), nodePrerequisites.end(),
-                        []( const auto& kv ) { return kv.second.find( kv.first ) != kv.second.end(); } ) );
+  auto it = std::find_if( nodePrerequisites.begin(), nodePrerequisites.end(),
+                          []( const auto& kv ) { return kv.second.find( kv.first ) != kv.second.end(); } );
+  if ( it != nodePrerequisites.end() ) {
+    throw GaudiException( "Node " + it->first->name() + " depends on itself.", __PRETTY_FUNCTION__,
+                          StatusCode::FAILURE );
+  }
 
   std::vector<gsl::not_null<VNode*>> ordered;
   std::set<gsl::not_null<VNode*>>    orderedSet;