Merge branch 'fix-point-write-access' into 'master'

Fix point write access

See merge request !4296

Kernel/LHCbMath/include/LHCbMath/Geom/XYZ.h

@@ -50,22 +50,40 @@ namespace LHCb::Geom {
     XYZ( const AltXYZ& xyz ) : _X( xyz.X() ), _Y( xyz.Y() ), _Z( xyz.Z() ) {}
 
   public:
+    // read access
+
+    /// X coordinate
+    inline const TYPE& X() const noexcept { return _X; }
+    /// Y coordinate
+    inline const TYPE& Y() const noexcept { return _Y; }
+    /// Z coordinate
+    inline const TYPE& Z() const noexcept { return _Z; }
     /// X coordinate
-    inline TYPE X() const noexcept { return _X; }
+    inline const TYPE& x() const noexcept { return X(); }
     /// Y coordinate
-    inline TYPE Y() const noexcept { return _Y; }
+    inline const TYPE& y() const noexcept { return Y(); }
     /// Z coordinate
-    inline TYPE Z() const noexcept { return _Z; }
+    inline const TYPE& z() const noexcept { return Z(); }
 
   public:
+    // write access
+
     /// X coordinate
-    inline TYPE x() const noexcept { return X(); }
+    inline TYPE& X() noexcept { return _X; }
     /// Y coordinate
-    inline TYPE y() const noexcept { return Y(); }
+    inline TYPE& Y() noexcept { return _Y; }
     /// Z coordinate
-    inline TYPE z() const noexcept { return Z(); }
+    inline TYPE& Z() noexcept { return _Z; }
+    /// X coordinate
+    inline TYPE& x() noexcept { return X(); }
+    /// Y coordinate
+    inline TYPE& y() noexcept { return Y(); }
+    /// Z coordinate
+    inline TYPE& z() noexcept { return Z(); }
 
   public:
+    // setters
+
     /// Set X
     inline void SetX( const TYPE x ) noexcept { _X = x; }
     /// Set Y
@@ -78,8 +96,6 @@ namespace LHCb::Geom {
       SetY( y );
       SetZ( z );
     }
-
-  public:
     /// Set X
     inline void setX( const TYPE x ) noexcept { SetX( x ); }
     /// Set Y

Rich/RichFutureMCUtils/src/component/DecodedDataFromMCRichHits.cpp

@@ -71,7 +71,7 @@ namespace Rich::Future::MC {
       std::map<LHCb::RichSmartID, std::vector<LHCb::MCRichHit*>> hitsPerPix;
       for ( const auto mchit : mchits ) {
         const auto id = mchit->sensDetID();
-        if ( mchit && id.isValid() ) {
+        if ( id.isValid() ) {
 
           // Apply all sorts MC based filtering here, e.g. signal only, timing windows etc.
           // To be extended as needed
@@ -157,7 +157,7 @@ namespace Rich::Future::MC {
     /** Temporary workaround for processing DetDesc MC as input.
      *  When active, applies corrections to the data to make compatible
      *  with the dd4hep builds. */
-    Gaudi::Property<bool> m_detdescMCinput{this, "IsDetDescMC", false};
+    Gaudi::Property<bool> m_detdescMCinput{this, "IsDetDescMC", true};
 
     /// Include time information in the decoded data
     Gaudi::Property<bool> m_includeTimeInfo{this, "IncludeTimeInfo", true};

Rich/RichFutureUtils/include/RichFutureUtils/RichSIMDMirrorData.h

@@ -60,20 +60,36 @@ namespace Rich::SIMD {
       TYPE _X{}, _Y{}, _Z{};
 
     public:
+      // read access
+
+      /// X coordinate
+      [[nodiscard]] const TYPE& X() const noexcept { return _X; }
+      /// Y coordinate
+      [[nodiscard]] const TYPE& Y() const noexcept { return _Y; }
+      /// Z coordinate
+      [[nodiscard]] const TYPE& Z() const noexcept { return _Z; }
       /// X coordinate
-      [[nodiscard]] TYPE X() const noexcept { return _X; }
+      [[nodiscard]] const TYPE& x() const noexcept { return X(); }
       /// Y coordinate
-      [[nodiscard]] TYPE Y() const noexcept { return _Y; }
+      [[nodiscard]] const TYPE& y() const noexcept { return Y(); }
       /// Z coordinate
-      [[nodiscard]] TYPE Z() const noexcept { return _Z; }
+      [[nodiscard]] const TYPE& z() const noexcept { return Z(); }
 
     public:
+      // write access
+
+      /// X coordinate
+      [[nodiscard]] TYPE& X() noexcept { return _X; }
+      /// Y coordinate
+      [[nodiscard]] TYPE& Y() noexcept { return _Y; }
+      /// Z coordinate
+      [[nodiscard]] TYPE& Z() noexcept { return _Z; }
       /// X coordinate
-      [[nodiscard]] TYPE x() const noexcept { return X(); }
+      [[nodiscard]] TYPE& x() noexcept { return X(); }
       /// Y coordinate
-      [[nodiscard]] TYPE y() const noexcept { return Y(); }
+      [[nodiscard]] TYPE& y() noexcept { return Y(); }
       /// Z coordinate
-      [[nodiscard]] TYPE z() const noexcept { return Z(); }
+      [[nodiscard]] TYPE& z() noexcept { return Z(); }
 
     public:
       /// send to std::ostream