Fixed floating point comparison in LHCbKernel tests

Kernel/LHCbKernel/tests/src/test_STLExtensions.cpp

@@ -52,7 +52,7 @@ BOOST_AUTO_TEST_CASE( range_single ) {
     auto single = LHCb::range::single{4.0};
     auto span   = LHCb::make_span( single );
     static_assert( span.extent == gsl::dynamic_extent ); // FIXME -- annoying that this isn't 1
-    BOOST_CHECK( sum( span ) == single.value() );
+    BOOST_CHECK_CLOSE( sum( span ), single.value(), 1e-4 );
     BOOST_CHECK( single.size() == 1 );
   }
 
@@ -64,9 +64,9 @@ BOOST_AUTO_TEST_CASE( range_single ) {
     auto e = LHCb::span<double, 1>{single};
     static_assert( e.extent == 1 );
     auto f = static_cast<LHCb::span<double, 1>>( single );
-    BOOST_CHECK( f[0] == single.value() );
+    BOOST_CHECK_CLOSE( f[0], single.value(), 1e-4 );
     auto g = static_cast<LHCb::span<double>>( single );
-    BOOST_CHECK( g[0] == single.value() );
+    BOOST_CHECK_CLOSE( g[0], single.value(), 1e-4 );
   }
 
   // check two ways of moving out of single...

Kernel/LHCbKernel/tests/src/test_arenaAllocator.cpp

@@ -12,6 +12,8 @@
 #define BOOST_TEST_MODULE example
 #include <boost/test/unit_test.hpp>
 
+#include "Core/FloatComparison.h"
+
 #include "Kernel/ArenaAllocator.h"
 #include "Kernel/Container.h"
 
@@ -167,7 +169,7 @@ public:
     double      d;
     char        c;
     friend bool operator==( const Data& lhs, const Data& rhs ) {
-      return lhs.i == rhs.i && lhs.d == rhs.d && lhs.c == rhs.c;
+      return lhs.i == rhs.i && LHCb::essentiallyEqual( lhs.d, rhs.d ) && lhs.c == rhs.c;
     }
   };
 

Kernel/LHCbKernel/tests/src/test_container.cpp

@@ -12,6 +12,8 @@
 #define BOOST_TEST_MODULE example
 #include <boost/test/unit_test.hpp>
 
+#include "Core/FloatComparison.h"
+
 #include "Kernel/ArenaAllocator.h"
 #include "Kernel/Container.h"
 
@@ -143,7 +145,8 @@ struct Pieces {
 
   friend bool operator==( const Pieces& lhs, const Pieces& rhs ) // C++20: just opt-in to operator<=>
   {
-    return lhs.i == rhs.i && lhs.f == rhs.f && lhs.d == rhs.d && lhs.c == rhs.c;
+    return lhs.i == rhs.i && LHCb::essentiallyEqual( lhs.f, rhs.f ) && LHCb::essentiallyEqual( lhs.d, rhs.d ) &&
+           lhs.c == rhs.c;
   }
 };