Merge branch 'rich-remove-pd-assert' into 'master'

Rich remove pd assert

See merge request !3706

Rich/RichDetectors/include/RichDetectors/RichPDPanel.h

@@ -156,7 +156,7 @@ namespace Rich::Detector {
       if ( pdID.pdIsSet() ) {
         const auto localModNum = panelLocalModNum( pdID );
         // Note, whilst comissioning dd4hep, but still using old DetDesc MC samples with
-        // different PMTs, we cannot apply assers here by instead must using runtime size checks.
+        // different PMTs, we cannot apply asserts here by instead must using runtime size checks.
         // to be reverted once dd4hep is fully comissioned and DetDesc completely dropped.
         // assert( localModNum < m_PDs.size() );
         if ( localModNum < pdModules().size() ) {
@@ -171,13 +171,13 @@ namespace Rich::Detector {
           }
         }
       }
+      // assert( dePD ); // cannot do this as long as 'classic' PMT support is required (see above).
       return dePD;
     }
 
     /// Check if a given PD ID is a 'large' H-Type PMT
     inline bool isLargePD( const LHCb::RichSmartID pdID ) const noexcept {
       const auto pd = dePD( pdID );
-      assert( pd );
       return ( pd ? pd->isHType() : false );
     }
 

Rich/RichFutureUtils/src/RichSmartIDs.cpp

@@ -64,6 +64,8 @@ RichSmartIDs::globalPositions( const Rich::PDPixelCluster::Vector& clusters, //
 
     // loop over the cluster info
     for ( const auto& clus : clusters ) {
+      // should never get a cluster with no asscoicated DePD object.
+      assert( clus.dePD() );
       // If new PD, or SIMD data is full, save and reset.
       if ( ( lastPD != clus.dePD() || index >= SIMDFP::Size ) && lastPD ) { saveInfo(); }
       // Fill info