Fixed formatting

patch generated by https://gitlab.cern.ch/lhcb/LHCb/-/jobs/24561750

remove print

David Hutchcroft authored 2 years ago and Sebastien Ponce committed 2 years ago

First implementation of TELL40 v1 cluster output (default) and two sensor SP banks (only if FPGA clustering not available)

Fixed formatting

patch generated by https://gitlab.cern.ch/lhcb/LHCb/-/jobs/20978478

Fixed formatting

patch generated by https://gitlab.cern.ch/lhcb/LHCb/-/jobs/20916309

Fixed formatting

patch generated by https://gitlab.cern.ch/lhcb/LHCb/-/jobs/20902973

Fixed formatting

patch generated by https://gitlab.cern.ch/lhcb/LHCb/-/jobs/20843061

Fixed formatting

patch generated by https://gitlab.cern.ch/lhcb/LHCb/-/jobs/20751144

removing debubbing print

Fixed formatting

patch generated by https://gitlab.cern.ch/lhcb/LHCb/-/jobs/20568802

changes to VPChannelID

Fixed formatting

patch generated by https://gitlab.cern.ch/lhcb/LHCb/-/jobs/19720086

Fixed formatting

patch generated by https://gitlab.cern.ch/lhcb/LHCb/-/jobs/19444242

Fixed formatting

patch generated by https://gitlab.cern.ch/lhcb/LHCb/-/jobs/19229634

small format changes

Fixed formatting

patch generated by https://gitlab.cern.ch/lhcb/LHCb/-/jobs/19241322

Changes to adopt new cluster format.
Introduced cut to SPmixer to account for firmware behavior.

Fixed formatting

patch generated by https://gitlab.cern.ch/lhcb/LHCb/-/jobs/19006912

Fixed formatting

patch generated by https://gitlab.cern.ch/lhcb/LHCb/-/jobs/19007189

Files dropped at this stage :
    Kernel/LHCbKernel/include/Kernel/CaloCellID.h
    Kernel/LHCbKernel/include/Kernel/FTChannelID.h
    Kernel/LHCbKernel/include/Kernel/MuonTileID.h
    Kernel/LHCbKernel/include/Kernel/UTChannelID.h
    Kernel/LHCbKernel/include/Kernel/VPChannelID.h
    Kernel/LHCbKernel/src/VPChannelID.cpp

The rest of the code has been adapted to use native namespace from the Detector package

- and thus, impliclicitly, to Gaudi::Algorithm
- also, migrate away from UTAlgBase:
   - specify DeUTDetector as dependency
   - use ToolHandle for readout tool
- prefer standalone functions in anonymous namespaces over member functions

- and adapt the code accordingly

also update version to 53.0

Removed MixedSP raw bank. RetinaClusterCreator and RetinaFullClustering have default location fo input SPs. SPmixer outputs to different RawEvent but default RawBank.

Added reduce_edge and fix_seed parameters to reduce matrix edges and fix seed for SP mixer. Fix bug to account for two clusters in the same isolated SP. Added accumulators in decoder. Added isolated, overflow, edge and sent contained bits to the 32-bit cluster word.

Fixed rounding, not truncation
Fixed 3x3 cluster reconstruction in case 2 clusters are found

Gitlab CI authored 5 years ago and Sebastien Ponce committed 5 years ago

patch generated by https://gitlab.cern.ch/lhcb/LHCb/-/jobs/7889032

adaptation of new code (after rebase) to drop of addCOnditionDerivation with single input not in an array

Federico Lazzari authored 5 years ago and Rosen Matev committed 5 years ago

VPRetinaMatrix: changed pattern for sensors on the modules back
VPRetinaClusterCreator: removed cluster sorting
VPRetinaFullClustering: creator of full cluster with pixel channelIDs

* use functional condition derivation
* amalgamate component headers into their corresponding source files
* prefer monadic StatusCode use
* prefer STL algortihms
* fix ltg indexing bug
* remove unused code

This is again preparation for the DD4hep introduction

This is in preparation to the move to DD4hep

* avoid copying sensors in loops
* remove redundant destructor, initialize
* do not explicitly cache the already implicitly cached output level
* prefer std::array and fill over raw array and memset
  (note: this does not change the generated assembly)
* prefer std::byte for 'raw' data
* replace the magic literal 208 with VP::NSensors
* prefer addBank over createBank/adoptBank
* prefer passing span to addBank instead of seperate length/pointer
* prefer stack memory for local working space