Follow-up from "Service to write luminosity information to TTree when reading from FSRs"

The following discussion from !4174 (merged) should be addressed:

• @pkoppenb started a discussion: (+3 comments)

  I see this has been merged. I don't think it's a good idea to merge MRs in LHCb that have effects on DaVinci before the corresponding DaVinci MR is approved. This line prints out stuff in info() spread over multiple lines. That's not following the Gaudi conventions. See an example here DaVinci!937 (diffs).

added Luminosity label

assigned to @egraveri and @efranzos

mentioned in merge request DaVinci!937 (merged)

Hi @erodrigu, @pkoppenb. I can move this printout https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/Kernel/FileSummaryRecord/tests/src/FSRTestAlgs.cpp#L54 in DEBUG and print the message in one line, do you think this solution correctly addresses the issue? It would be something like

InputFSRSpy DEBUG got FSR from input file: {"LumiCounter.eventsByRun":{"counts":{"255620":12381},"empty":false,"type":"LumiEventCounter"},"guid":"7CFA8B3C-3A05-11EE-A38B-FA163EE901C1"}

Looks good to me. Thanks.

If you make the message only appear at DEBUG, why run this service? It seems the only thing the service does is to print this message. So if this is not wanted, then just not include the service into the configuration, as we should not be running things that do not have any observable effect.

Right. As the namespace indicates this algo is for tests, and "spying". That should not run in standard DaVinci jobs and I made that comment at DaVinci!937 (comment 7061725). Tests can go in debug level.

ok, so I'm removing the service (DaVinci!937 (comment 7061725)) from config.py. I will also print the InputFSRSpy message in one line. Do you prefer to keep the printout in INFO at this point?

Is InputFSRSpy just there to spy? I.e. it doesn't do anything else than print? If so, yes, it should be in INFO as people adding it to spy want to see the output (Like PrintDecayTree'). If it does more, then it should be as silent as possible.

Yes, it seems so. I've removed the service from the configuration DaVinci!937 (483d7abe). We will keep InputFSRSpy printout in INFO.

Sure, sounds good to me also, assuming things will run with INFO level by default.

created branch 327-follow-up-from-service-to-write-luminosity-information-to-ttree-when-reading-from-fsrs to address this issue

created branch 327-follow-up-from-service-to-write-luminosity-information-to-ttree-when-reading-from-fsrs-2 to address this issue

mentioned in merge request !4270 (merged)

closed with merge request !4270 (merged)

mentioned in commit 3b58eb4d

mentioned in merge request !4284 (merged)