Skip to content
Snippets Groups Projects

Do not try to unpack Turbo for non-Turbo jobs

Merged Alex Pearce requested to merge apearce-accidental-turbo-unpacking into 2018-patches
All threads resolved!

This addresses some problems reported on the mailing list about crashes related to Turbo unpacking.

The issue was that Turbo unpacking was being triggered by an MC relations algorithm looking up Turbo locations by default, which the ParticlesToVerticesMapper tries to provide for. The unpacking fails because the job is not configured to process Turbo data (the RootInTES is incorrect).

This MR modifies ParticlesToVerticesMapper so that one can configure a list of streams to ignore, e.g. /Event/Turbo, under which the mapper will not try to unpack data. I've also modified DstConf to configure the mapper.

This fix should be also ported to 2017-patches.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks, does this patch apply to all years of data taking or is it only needed for 2017+ MC?

  • assigned to @jonrob

  • Author Contributor

    It's needed for running over any MC sample which contains Turbo information, when the job isn't configured as a Turbo job.

  • Alex Pearce resolved all discussions

    resolved all discussions

  • Alex Pearce added 1 commit

    added 1 commit

    • fe7aac35 - Append in case the value has been set already.

    Compare with previous version

  • Marco Cattaneo mentioned in commit 8806441e

    mentioned in commit 8806441e

  • Marco Cattaneo mentioned in commit a32d9ec0

    mentioned in commit a32d9ec0

  • Marco Cattaneo mentioned in merge request !1141 (merged)

    mentioned in merge request !1141 (merged)

  • Marco Cattaneo mentioned in merge request !1142 (merged)

    mentioned in merge request !1142 (merged)

  • Marco Cattaneo mentioned in commit bbf0ef2f

    mentioned in commit bbf0ef2f

  • Marco Cattaneo mentioned in commit 97bc6722

    mentioned in commit 97bc6722

  • Marco Cattaneo mentioned in commit 833433c9

    mentioned in commit 833433c9

  • Marco Cattaneo mentioned in merge request !1343 (merged)

    mentioned in merge request !1343 (merged)

  • Please register or sign in to reply
    Loading