Fix AWM functor.
Fix for LHCBPS-1778
Merge request reports
Activity
@ibelyaev you were.... See !726 (merged) - you even wrote "it should be fine" in the last comment...
@malexand @erodrigu I guess this means I have to release a new patch stack (since the currently tagged one was released up to Brunel today.....). @rmatev @sstahl it wasn't entirely clear to me if this affects also Moore - in which case I should make an urgent patch release tomorrow - or if it only affects stripping - in which case we have a bit more time...
There is one line using the AWM functor and it uses it in a way which is affected. And as @olupton points out other functors which are used in other lines are likely affected as well. I thin k we have to fix it then.
Edited by Sascha Stahl- Resolved by Marco Cattaneo
added 1 commit
- b4da00f7 - Implement the fix using std::inner_product instead.
- [2018-04-11 00:06] Validation started with lhcb-moore-test#23
- [2018-04-11 00:51] Validation started with lhcb-2018-patches#176
- [2018-04-11 09:33] Validation started with lhcb-moore-test#23
- [2018-04-11 09:35] Validation started with lhcb-2018-patches#176
- [2018-04-12 00:06] Validation started with lhcb-moore-test#24
- [2018-04-12 00:08] Validation started with lhcb-2018-patches#177
- [2018-04-12 11:29] Validation started with lhcb-2018-patches#178
Edited by Software for LHCbmentioned in merge request !1223 (merged)
mentioned in commit 11d5a96b
mentioned in commit 6b4daa14
mentioned in merge request !1234 (merged)