Make RawBanks returned from RawEvent 'const'

• which implies changing the return type of LHCb::RawEvent::banks, from std::vector<RawBank*> to LHCb::span<const RawBank*> and fixing the fall-out
• add const in lots of places
• prefer auto over explicitly specifying the type, to make the code less dependent on concrete types, and more on behaviour

@cattanem: add labels / unWIP / merge at your leisure, but only after Lbcom!264 (merged) , Rec!1124 (merged), Phys!388 (merged), Hlt!587 (merged) have been merged... (as those can be applied independent of this MR, but have to be present when this is applied)

added 1 commit

• 25caa1ee - Make RawBanks returned from RawEvent 'const'

Compare with previous version

added 1 commit

• 4a5987ad - Make RawBanks returned from RawEvent 'const'

Compare with previous version

added 1 commit

• d2692388 - Make RawBanks returned from RawEvent 'const'

Compare with previous version

assigned to @cattanem

mentioned in merge request Hlt!587 (merged)

• [2018-08-01 00:10] Validation started with lhcb-gaudi-head#1948
• [2018-08-02 00:11] Validation started with lhcb-gaudi-head#1949
• [2018-08-03 00:10] Validation started with lhcb-gaudi-head#1950
• [2018-08-04 00:14] Validation started with lhcb-gaudi-head#1951
• [2018-08-05 00:07] Validation started with lhcb-gaudi-head#1952
• [2018-08-06 00:07] Validation started with lhcb-lcg-dev3#609
• [2018-08-06 00:10] Validation started with lhcb-head#1941
• [2018-08-06 00:11] Validation started with lhcb-lcg-dev4#608
• [2018-08-06 00:12] Validation started with lhcb-gaudi-head#1953
• [2018-08-06 00:13] Validation started with lhcb-tdr-test#244

@graven, a patch is needed also for Vetra, see https://lhcb-nightlies.cern.ch/logs/build/nightly/lhcb-gaudi-head/1948/x86_64-centos7-gcc7-opt/Vetra/

added 14 commits

• d2692388...cd941684 - 13 commits from branch master
• 89baad6f - Make RawBanks returned from RawEvent 'const'

Compare with previous version

@cattanem: is there a need for the changes to vetra to be both forward & backwards compatible (i.e. must vetra master continue work with eg. 2018-patches), or is it OK to assume that vetra master only has to work with lhcb master (i.e. can I update vetra in a way which assumes this MR is applied, and avoid writing more complicated code which is 'blind' to the differences)

@graven, as far as I can see Vetra is only ever released on master, so the backwards incompatible fix should be fine. Copying @maszyman and @tszumlak for confirmation, but I suggest you go ahead with the simple fix which can be made more complicated later if necessary.

mentioned in commit Vetra@7f0d8648

mentioned in merge request Vetra!22 (merged)

Done, see Vetra!22 (merged)

Please look at failing tests in https://lhcb-nightlies.cern.ch/logs/tests/nightly/lhcb-gaudi-head/1949/x86_64-slc6-gcc7-opt/LHCb/ and https://lhcb-nightlies.cern.ch/logs/tests/nightly/lhcb-gaudi-head/1949/x86_64-slc6-gcc7-opt/Rec/ which are caused by this MR

added 1 commit

• 56e39730 - Make RawBanks returned from RawEvent 'const'

Compare with previous version

fixed, see here

added 1 commit

• 519600ef - Make RawBanks returned from RawEvent 'const'

Compare with previous version

And the same logical mistake was introduced in a few more places -- now fixed... (see here)