Skip to content

Fix an issue with LHCb::Vector::Mem::Iterator constructor highlighted by gcc8 warning

Christopher Rob Jones requested to merge LHCbKernel-FixVectorSOAIteratorConstructorGcc8Warning into master

Addresses the warning

/usera/jonesc/LHCbCMake/Feature/LHCb/InstallArea/x86_64-centos7-gcc8-dbg+o1+lsan/include/Kernel/VectorSOAIterator.h: In constructor ‘LHCb::Vector::Mem::Iterator<PRECISION>::Iterator(LHCb::Vector::Mem::Store<PRECISION>&, const bool&)’:
/usera/jonesc/LHCbCMake/Feature/LHCb/InstallArea/x86_64-centos7-gcc8-dbg+o1+lsan/include/Kernel/VectorSOAIterator.h:49:15: warning: unnecessary parentheses in declaration of ‘store’ [-Wparentheses]
       Iterator(store);

looking at the above, I suspect that previously the code was not quite working as intended, as the line

Iterator(store);

was declaring a local Iterator called store rather than what I guess was the intended behaviour which was call another constructor (which I don't think is allowed as tried above).

Merge request reports