Fix dangerous DeVP::sensor interface

• deprecate sensorOfChannel(const LHCb::VPChannelID channel)
• add sensor(LHCb::VPChannelID channel) const

The reason for this change is that there is already sensor(unsigned int sensorNumber) const, and because there is an implicitly defined conversion from VPChannelID to unsigned int, one can invoke sensor already with a VPChannelID, which will result in an out-of-bounds access. To avoid this, the overload of sensor for VPChannelID is added, at which point there is no use anymore for sensorOfChannel...

@cattanem: please label / unWIP / merge at your leisure

(note: this will generate a number of deprecation warnings which can be fixed in subsequent MRs, after which the deprecated method can be removed)

added 9 commits

• f5c7601f...f0b412b6 - 8 commits from branch master
• 5a5a0fa4 - Fix dangerous DeVP::sensor interface

Compare with previous version

added 1 deleted label

• [2019-01-13 00:08] Validation started with lhcb-tdr-test#421
• [2019-01-14 00:10] Validation started with lhcb-tdr-test#422
• [2019-01-15 00:08] Validation started with lhcb-tdr-test#423
• [2019-01-16 00:07] Validation started with lhcb-tdr-test#424
• [2019-01-16 11:13] Validation started with lhcb-tdr-test#424
• [2019-01-17 00:08] Validation started with lhcb-tdr-test#425
• [2019-01-18 00:09] Validation started with lhcb-tdr-test#426
• [2019-01-19 00:05] Validation started with lhcb-tdr-test#427
• [2019-01-25 00:07] Validation started with lhcb-gaudi-head#2139
• [2019-01-26 00:07] Validation started with lhcb-gaudi-head#2140
• [2019-01-27 00:03] Validation started with lhcb-dd4hep#133
• [2019-01-27 00:03] Validation started with lhcb-sanitizers#138
• [2019-01-27 00:04] Validation started with lhcb-lcg-dev4#791
• [2019-01-27 00:05] Validation started with lhcb-lcg-dev3#785
• [2019-01-27 00:06] Validation started with lhcb-gaudi-head#2141
• [2019-01-27 00:06] Validation started with lhcb-head#2128
• [2019-01-27 00:07] Validation started with lhcb-tdr-test#435

@graven please look at (and fix?) deprecation warnings in
https://lhcb-nightlies.cern.ch/logs/build/nightly/lhcb-tdr-test/421/x86_64-centos7-gcc7-opt/Lbcom/
https://lhcb-nightlies.cern.ch/logs/build/nightly/lhcb-tdr-test/421/x86_64-centos7-gcc7-opt/Rec/
https://lhcb-nightlies.cern.ch/logs/build/nightly/lhcb-tdr-test/421/x86_64-centos7-gcc7-opt/Alignment/

added 5 commits

• 5a5a0fa4...9e820c0e - 4 commits from branch master
• dd6f175a - Fix dangerous DeVP::sensor interface

Compare with previous version

mentioned in commit Lbcom@97ea847d

mentioned in merge request Lbcom!311 (merged)

@graven Could you please fix the deprecation warnings in Rec and Alignment?

The ones in Rec are fixed as part of Rec!1359 (merged) and Rec!1361 (merged) (as they are the reason I made this MR in the first place!) The one in Alignment I can make a MR for...

Hmmmmm.... It means I have to live with the warnings until those two are commissioned... Any way they can factored out?

added 3 commits

• dd6f175a...448463b1 - 2 commits from branch master
• 80602a62 - Fix dangerous DeVP::sensor interface

Compare with previous version

Everything is possible, but I'd hope that once Rec!1362 (merged) is signed off, then Rec!1359 (merged) and Rec!1361 (merged) will follow very shortly there after...

mentioned in commit Lbcom@56d88ffe

mentioned in commit Lbcom@0d79e316

removed 1 deleted label

added 1 deleted label

@graven, (finally) coming back to this. Not all Rec deprecation warnings were fixed in Rec!1359 (merged) and Rec!1361 (merged), there are still a few left, see https://lhcb-nightlies.cern.ch/logs/build/nightly/lhcb-gaudi-head/2139/x86_64-centos7-gcc7-opt/Rec/

mentioned in merge request !1715 (merged)