fix bug in PiecewiseTrajectory (@graven)

Fix for the bug discussed in !1695 (merged) and LHCBPS-1816. Not to be merged until impact on data and alignment has been evaluated. When applied, should fix the test in !1710 (merged)

@graven @sborghi @wouter FYI

mentioned in merge request !1710 (merged)

OK, I'll try to find half a day this week to run some alignment with and without the bug fix and look at the results.

changed title from WIP fix bug in PiecewiseTrajectory to WIP fix bug in PiecewiseTrajectory (@graven)

changed the description

unmarked as a Work In Progress

• [2019-02-01 00:04] Validation started with lhcb-run2-patches#277
• [2019-02-03 00:05] Validation started with lhcb-run2-patches#279
• [2019-02-04 00:08] Validation started with lhcb-run2-patches#280
• [2019-02-05 00:04] Validation started with lhcb-run2-patches#281
• [2019-02-06 00:07] Validation started with lhcb-run2-patches#282

If anyone is interested, I (temporarily) enabled this MR in today's nightly - the Brunel diffs are here: https://lhcb-nightlies.cern.ch/logs/tests/nightly/lhcb-run2-patches/277/x86_64-centos7-gcc62-opt/Brunel/. See also the Escher diffs: https://lhcb-nightlies.cern.ch/logs/tests/nightly/lhcb-run2-patches/277/x86_64-centos7-gcc62-opt/Alignment/

marked as a Work In Progress

changed the description

mentioned in merge request Brunel!633 (merged)

mentioned in merge request Alignment!88 (merged)

For a documentation of the size of the effect on Brunel reconstruction, see Brunel!633 (merged)

Similarly, for Alignment tests: Alignment!88 (merged)

unmarked as a Work In Progress

removed 1 deleted label

mentioned in commit Brunel@91ba6658

mentioned in commit 67c545dd

merged

mentioned in commit Alignment@73e5edde