Prefer CaloIndex enum over plain (unsigned) int, move some Calo Interfaces to Rec
Prefer enum over plain (unsigned) int for increased type safety Move several Calo (Future) Interfaces into Rec, into the sole package using them.
must be applied in conjunction with Rec!1701 (merged), Phys!604 (merged), and Panoramix!53 (merged).
Edited by Marco Cattaneo
Merge request reports
Activity
mentioned in merge request Rec!1701 (merged)
- [2019-09-25 00:05] Validation started with lhcb-lcg-dev4#1041
- [2019-09-26 00:04] Validation started with lhcb-lcg-dev4#1042
- [2019-09-27 00:04] Validation started with lhcb-lcg-dev4#1043
Edited by Software for LHCbadded 11 commits
-
70576a40...9242abd1 - 4 commits from branch
master
- b191d237 - Use functional conditions access
- 766df1d7 - throw exception with hint instead of SEGV a few lines later
- 126e168e - avoid aliases in conditions name which requires updateHandler
- 9b1d6826 - add a test case which just runs the Ecal & Hcal decoding
- 1dc75e48 - hack to make sure user_dest_ptrs are always set
- 21875d46 - Move {,I}CaloFutureDigitFilterTool to Rec/CaloFuture/CaloFutureReco
- 63d75f00 - Prefer enum over plain (unsigned) int for increased type safety
Toggle commit list-
70576a40...9242abd1 - 4 commits from branch
added 1 commit
- bf746f18 - Prefer enum over plain (unsigned) int for increased type safety
- Resolved by Marco Cattaneo
@graven are your latest commits from today addressing the issues in
lhcb-lcg-dev4
today? See failing tests in https://lhcb-nightlies.cern.ch/logs/tests/nightly/lhcb-lcg-dev4/1041/x86_64-centos7-gcc8-opt/LHCb/ and failing compilation in https://lhcb-nightlies.cern.ch/logs/build/nightly/lhcb-lcg-dev4/1041/x86_64-centos7-gcc8-opt/Boole/
added 7 commits
- fdf11524 - avoid aliases in conditions name which requires updateHandler
- d5657551 - add a test case which just runs the Ecal & Hcal decoding
- 4c100c55 - throw exception with hint instead of SEGV a few lines later
- 538b03df - hack to make sure user_dest_ptrs are always set
- c1ee1c84 - Use functional conditions access
- 96b76bb5 - Move {,I}CaloFutureDigitFilterTool to Rec/CaloFuture/CaloFutureReco
- 4b2b1470 - Prefer enum over plain (unsigned) int for increased type safety
Toggle commit listadded 1 commit
- 54dd1b71 - Prefer enum over plain (unsigned) int for increased type safety
added 1 commit
- d5b01a22 - Prefer enum over plain (unsigned) int for increased type safety
added 19 commits
-
d5b01a22...7945ba8b - 12 commits from branch
master
- c8f5d931 - Use functional conditions access
- 1f121bc5 - avoid aliases in conditions name which requires updateHandler
- 63ac183c - add a test case which just runs the Ecal & Hcal decoding
- 91a0b15c - throw exception with hint instead of SEGV a few lines later
- 963b0a18 - hack to make sure user_dest_ptrs are always set
- b988e45d - Use functional conditions access
- 6371bb8e - Prefer enum over plain (unsigned) int for increased type safety
Toggle commit list-
d5b01a22...7945ba8b - 12 commits from branch
- Resolved by Gerhard Raven
added 1 commit
- b663f764 - Prefer enum over plain (unsigned) int for increased type safety
added 1 commit
- 91a6d266 - Prefer enum over plain (unsigned) int for increased type safety
Please register or sign in to reply