Det/CaloDet: run clang-tidy
- run
clang-tidy -checks=modernize-\*,cppcoreguidelines-\*,clang-analyzer-\*,bugprone-\*
- move code from DeCalorimeter.icpp into either DeCalorimeter.h or DeCalorimeter.cpp
- move
operator<<
out of global scope into class scope when possible - change
DeSubCalorimeter::side
from anint
to anenum class
- prefer
const_cast
over c-style cast