Skip to content
Snippets Groups Projects

Minimize new refs produced by validateWithRef

Merged Rosen Matev requested to merge rmatev-slim-refs into master
  • For tests using validateWithRef, only the preprocessed stdout is written out on failure. Standard preprocessors would filter out the summary tables, which is why the counter tables, TTree and histogram summaries are extracted and written out at the end. In this way irrelevant lines would not be part of the ref files, thereby reducing diffs and conflicts.
  • Fix a bug in the counter extraction where any component (tool) with a dot in the name would not be considered in the comparison.
  • Catch exceptions in the validators and put the traceback in a validator_exception field.
  • Expose the counter parsing with a standalone extract_counters.
  • Add a preprocessor GroupMessages that groups multi-line messages.
  • Add a preprocessor BlockSkipper that improves upon the BlockSkipper from Gaudi (can be moved there).

goes together with Moore!339 (merged)

Edited by Rosen Matev

Merge request reports

Pipeline #1305677 passed

Pipeline passed for 1eb03854 on rmatev-slim-refs

Merged by Alex PearceAlex Pearce 5 years ago (Dec 18, 2019 1:06pm UTC)

Loading

Pipeline #1305788 passed

Pipeline passed for 3269fa2b on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alex Pearce
  • Alex Pearce
  • Alex Pearce
  • Alex Pearce
  • Alex Pearce
  • Looks great, thanks a lot.

  • Alex Pearce mentioned in merge request Rec!1838 (merged)

    mentioned in merge request Rec!1838 (merged)

  • Rosen Matev added 1 commit

    added 1 commit

    • 6f93c6e5 - Apply suggestion to GaudiConf/python/GaudiConf/QMTest/LHCbExclusions.py

    Compare with previous version

  • Rosen Matev added 1 commit

    added 1 commit

    • f156c214 - Apply suggestion to GaudiConf/python/GaudiConf/QMTest/LHCbTest.py

    Compare with previous version

  • Rosen Matev added 1 commit

    added 1 commit

    • ee82cab6 - Apply suggestion to GaudiConf/python/GaudiConf/QMTest/LHCbTest.py

    Compare with previous version

  • Rosen Matev added 9 commits

    added 9 commits

    Compare with previous version

  • mentioned in commit Moore@7efa5152

  • Rosen Matev resolved all threads

    resolved all threads

  • Rosen Matev changed the description

    changed the description

  • mentioned in commit Moore@bde51873

  • Alex Pearce mentioned in merge request Rec!1817 (merged)

    mentioned in merge request Rec!1817 (merged)

  • Rosen Matev added 1 commit

    added 1 commit

    • 1eb03854 - Minimize new refs produced by validateWithRef

    Compare with previous version

  • Alex Pearce resolved all threads

    resolved all threads

  • Alex Pearce approved this merge request

    approved this merge request

  • All looks grand to me, thanks a lot!

  • merged

  • Alex Pearce mentioned in commit 3269fa2b

    mentioned in commit 3269fa2b

  • Rosen Matev mentioned in merge request Brunel!928 (merged)

    mentioned in merge request Brunel!928 (merged)

  • Rosen Matev mentioned in commit c4036bc5

    mentioned in commit c4036bc5

  • Rosen Matev mentioned in merge request !2292 (merged)

    mentioned in merge request !2292 (merged)

  • Rosen Matev mentioned in merge request !2308 (merged)

    mentioned in merge request !2308 (merged)

  • mentioned in commit Brunel@cbca52fe

  • Rosen Matev mentioned in merge request Brunel!931 (merged)

    mentioned in merge request Brunel!931 (merged)

  • mentioned in commit Brunel@88c714fd

  • mentioned in commit Moore@a1d3fade

  • Rosen Matev mentioned in merge request Moore!357 (merged)

    mentioned in merge request Moore!357 (merged)

  • mentioned in commit Moore@192600bb

  • mentioned in commit Moore@912b2b84

  • Rosen Matev mentioned in commit 7895a864

    mentioned in commit 7895a864

  • Rosen Matev mentioned in merge request !2314 (merged)

    mentioned in merge request !2314 (merged)

  • Rosen Matev added Build label and removed testing label

    added Build label and removed testing label

  • added highlight label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading