Modernize MCEvent
- add initializers to member declarations and make default constructors = default
- add [[nodiscard]] where appropriate
- add some const
- have setters take their argument by value, and then std::move to the destination
- have setters return *this (instead of void) to allow daisy-chaining
- remove redundant protected declarations
- remove redundant inline declarations
- remove redundant destructors
- prefer STL algorithms over raw loops
- prefer range-based for loops
- prefer auto instead of ...::iterator
- remove pragmas specific to Intel compiler
- prefer using over typedef
- remove x bit from header files
must be applied in conjunction with Lbcom!414 (merged) and Boole!254 (merged)
Merge request reports
Activity
added Event model backport run2 cleanup modernisation labels
- Resolved by Marian Stahl
/ci-test --merge
mentioned in merge request Lbcom!414 (merged)
mentioned in merge request Boole!254 (merged)
assigned to @mstahl
@graven you have labelled this MR with "EventModel". Could you please highlight the changes related to the EventModel in the description to make them easier to distinguish them from the modernisation-changes (if that's possible and makes sense).
There are no functional changes to the event model itself -- except that 'setters' now return a reference to
*this, which allows then to be daisy-chained, and 'getters' have gotten a[[nodiscard]]qualification, as just calling them has no affect -- so the return value better be used somehow...added lhcb-gaudi-head label
removed lhcb-gaudi-head label
Resolved by Rosen Matev@mstahl I think Boole is failing today on lhcb-gaudi-head because this MR wasn't in.
- Last reply by Marian Stahl
mentioned in commit b166814d
unassigned @rmatev
mentioned in issue Moore#128 (closed)