Enable event-local memory pool for LHCb::Pr::Velo::{Hits,Tracks}

Uses the custom allocator of !2270 (merged) in LHCb::Pr::Velo::{Hits,Tracks}.

Targets the branch of !2270 (merged) so the diff is correct. Hopefully we can merge that one imminently; for now this makes the diff appear correctly.

Without Rec!1892 (merged) the behaviour is unchanged (i.e. a default-constructed container uses the system allocator), but it's probably efficient to test in parallel with that MR.

cc: @ahennequ

mentioned in merge request Rec!1892 (merged)

changed the description

mentioned in merge request Rec!1896 (merged)

mentioned in merge request !2313 (closed)

changed the description

mentioned in issue #73 (closed)

@ahennequ please hit "Approve" once you've checked and are ok.

added Tracking enhancement labels

assigned to @ahennequ

approved this merge request

added lhcb-head label

changed target branch from olupton_custom_allocators to master

• [2020-01-31 00:06] Validation started with lhcb-head#2498
• [2020-02-01 00:08] Validation started with lhcb-head#2499
• [2020-02-02 00:08] Validation started with lhcb-head#2500
• [2020-02-04 00:05] Validation started with lhcb-head#2501
• [2020-02-05 00:07] Validation started with lhcb-head#2502
• [2020-02-06 00:05] Validation started with lhcb-head#2503
• [2020-02-06 00:20] Validation started with lhcb-head#2503
• [2020-02-06 00:34] Validation started with lhcb-head#2503
• [2020-02-07 00:05] Validation started with lhcb-head#2504

mentioned in issue Moore#131 (closed)

added 34 commits

• a5b2965f...b4285888 - 20 commits from branch master
• edcb4750 - Prefer LHCb::span to std::vector const& as an argument type.
• 5cd14dc5 - Fix private member access from non-friend.
• 0689969a - Import Gaudi::Arena::Monotonic.
• c630728d - Add LHCb-specific EventContext extension.
• 926b6a4c - Add LHCb::Allocators::{Memory,MonotonicBuffer}Resource.
• 59ec9c62 - Add LHCb::Allocators::EventLocal<T>
• d2898bfe - Create and use an event-local memory pool in the scheduler.
• fc0da1ec - Add memory pool statistics to the standard list of exclusions.
• ac043d9c - Make LHCb::Allocators::EventLocal<T> default to using new/delete, add...
• e63a8c1c - Make LHCb::getMemResource( EventContext{} ) return nullptr and mark it always_inline.
• 95464d7a - Add LHCb::make_obj_propagating_allocator<T>( old, args... ) helper.
• 083eb223 - [Hopefully] fix compiler warning in debug builds.
• 1f102fd8 - Try and avoid clang8 compilation errors.
• f2b1d329 - Make containers relevant to the VELO reconstruction allocator-aware.

Compare with previous version

added 17 commits

• f2b1d329...1fa18099 - 2 commits from branch master
• 3a3c0533 - Prefer LHCb::span to std::vector const& as an argument type.
• efb23197 - Fix private member access from non-friend.
• cf536017 - Import Gaudi::Arena::Monotonic.
• d5dc63e2 - Add LHCb-specific EventContext extension.
• 6ce332f8 - Add LHCb::Allocators::{Memory,MonotonicBuffer}Resource.
• 18a468d3 - Add LHCb::Allocators::EventLocal<T>
• d3257cb9 - Create and use an event-local memory pool in the scheduler.
• a04efc59 - Add memory pool statistics to the standard list of exclusions.
• c2d74898 - Make LHCb::Allocators::EventLocal<T> default to using new/delete, add...
• 1b1dd278 - Make LHCb::getMemResource( EventContext{} ) return nullptr and mark it always_inline.
• 71470ee1 - Add LHCb::make_obj_propagating_allocator<T>( old, args... ) helper.
• e17b9b74 - [Hopefully] fix compiler warning in debug builds.
• a9a688fa - Try and avoid clang8 compilation errors.
• 25e5092d - Explicitly specify boost::container::small_vector default allocator to sidestep cling error.
• 631676a1 - Make containers relevant to the VELO reconstruction allocator-aware.

Compare with previous version

removed lhcb-head label

merged

mentioned in commit 28223ab9