Add context methods to LoKi::Hybrid::GenEngine
Follows !1549 (merged), adding back support for LoKi functors under the GenEngine
actor (used in generator-level cuts).
Closes LHCBGAUSS-1833.
/cc @ibelyaev
Merge request reports
Activity
added Simulation lhcb-head labels
added bug fix label
- [2020-01-29 00:07] Validation started with lhcb-head#2496
- Resolved by Alex Pearce
Could we please add a test that demonstrates the bug and the fix?
added 1 commit
- 51d81576 - Add context methods to LoKi::Hybrid::GenEngine.
removed lhcb-head label
I took a quick look at Gauss qmtests failing due to this and it seems that is works, since one test is successful (https://lhcb-nightlies.web.cern.ch/logs/tests/nightly/lhcb-head/2496/x86_64-centos7-gcc9-opt/Gauss/#all_47) and the other fails due to a time-out (https://lhcb-nightlies.web.cern.ch/logs/tests/nightly/lhcb-head/2496/x86_64-centos7-gcc9-opt/Gauss/#all_49) and normally the failure is at initialisation as it can be seen in a different slot (https://lhcb-nightlies.web.cern.ch/logs/tests/nightly/lhcb-gaudi-head/2517/x86_64-centos7-gcc9-opt/Gauss/#all_47)
I would like this to be deployed in the next version of LHCb since the plan is to use that for the release of Gauss v54r0 for Sim10 and upgrade
unassigned @dmuller
mentioned in commit 37bc7e4a
mentioned in issue Gauss#1 (closed)
added highlight label
13 from Configurables import LoKi__GenFilter as GenFilter 14 15 # TODO why is this still needed? (taken from LHCbApp) 16 from Configurables import AlgContextSvc 17 AlgContextSvc(BypassIncidents=True) 18 19 # Get rid of warnings 20 HistogramPersistencySvc().OutputLevel = 5 21 LoKiSvc().Welcome = False 22 23 algorithm = GenFilter( 24 'Algorithm', 25 Preambulo=[ 26 """ 27 # Check that GSOURCE is decorated correctly 28 print "Algorithm, GSOURCE =", GSOURCE @apearce this breaks with Python3, see https://lhcb-nightlies.web.cern.ch/logs/tests/nightly/lhcb-gaudi-head-py3/298/x86_64-centos7-gcc9-opt/LHCb/#failures_533
Is there a way it can be fixed to work with both Python2 and Python3?
It's this specific line that breaks? Yes, this just needs wrapping.
print(print "Algorithm, GSOURCE =", GSOURCE)
I did patch HybridBase to import the
print
function, so the change here will also produce an error in a Python 2 build. (Thinking about it, we should have a Python 2 build for the Python 3 MR!)Edited by Alex Pearce