Skip to content

Set DeterministicPrescaler seed with an explicit property

Alex Pearce requested to merge apearce-prescaler-seed-property into master

As explained in Moore#74 (closed), modern usage of Configurables relies less on explicit naming, so the reliance on the name to set the random seed in DeterministicPrescaler can be problematic. This MR adds a property to that algorithm, which is used as the seed rather than the name, and requires it to be set to a non-empty string.

Because the algorithm now returns an Error in initialize when the new property has its default value, I expect this MR to cause lots of test failures. Will open MRs in downstream projects after a ci-test cycle.

Downstream MRs: Phys!676 (merged) Moore!397 (merged) DaVinci!370 (merged)

Edited by Alex Pearce

Merge request reports

Loading