fix test_public_headers_build test target

• add missing include in public header
• delete (seemingly) unused header ← this is why I wip'ed as I believe this is potentially harmful
• explicitly state include dependency in cmake lists file (w/o default build target)

The idea is that if one has a cpp file with only one line #include "public_header.h", where public_header.h is a file that we install in InstallArea/…/include, then that file should compile without errors and warnings. Ideally that helps when sorting header files alphabetically.

@jonrob: as you can see in the changes, I deleted a Rich header which I didn't see used anywhere (in my checkout of projects until Moore and with lb-glimpse until DaVinci). istm like LookupTableInterpolator.h wasn't included anywhere, but I believe it's still good if somebody who knows about RichUtiles can confirm it's obsolete.

@clemenci: the edition of the cmake lists file shouldn't do anything visible in a standard build but maybe it's good to have the include dependency known when migrating to the new configuration?

@ibelyaev: I edited TreeHelpers.h because it uses Decays::Node m_head = Decays::Nodes::Invalid, which means having Decays::Nodes::Invalid defined is a good idea. This isn't an issue when building LHCb as all files which included TreeHelpers.h seem to have included Kernel/Nodes.h (through NodesPIDs.h in the case I looked at) as well.

I would prefer you to not delete the RICH header, at least not at this stage. Its true it is currently not used anywhere at this point, but that might change.

added 1 commit

• 2448024f - formatting (SQUASHME)

Compare with previous version

changed the description

resolved all threads

added 2 commits

• 884faa47 - fix test_public_headers_build test target
• e92208f8 - formatting (SQUASHME)

Compare with previous version

@clemenci shall we unwip this ? Or do we rather close it ?

I think that it is important that the headers can be compiled by themselves.

I do not like the change in the CMakeLists.txt file, but that's really the only way until we move to the new configuration.

I'd suggest we merge, so that I'll have a reminder when migrating that subdirectory to the new configuration.

unmarked as a Work In Progress

changed the description

resolved all threads

assigned to @peilian

added ci-test-triggered label

• [2020-11-02 19:22] Validation started with lhcb-master-mr#1511

added lhcb-head-2 label

removed lhcb-head-2 label

assigned to @sponce and unassigned @peilian

assigned to @peilian

resolved all threads

merged

mentioned in commit ca30a1d5