QMTest of CopyInputStream

• Add a QMTest that an LHCb App can use CopyInputStream introduced in the Gaudi development gaudi/Gaudi!1077 (merged):

• Add CopyInputStream to the _knownOutputStreams in IOHelper.py.

mentioned in merge request gaudi/Gaudi!1077 (merged)

can we please change the name NewInputCopyStream to something else, as in future, when this won't be new anymore, the name will be confusing... Perhaps CopyInputStream?

Sure. I always feel the old name is just a temporary solution, and CopyInputStream sounds good to me.

Because you've already added tests in gaudi/Gaudi!1077 (merged), I think most of the tests here are redundant as they all test the same thing: the algorithm runs and it writes out the expected locations.

The only LHCb-specific thing I can think of is that IOHelper knows about CopyInputStream, and that an LHCb application is able to run with it. We don't need the IOTest for that, just something simple:

from Configurables import (
    ApplicationMgr,
    Gaudi__Hive__FetchLeavesFromFile as FetchLeavesFromFile,
    LHCbApp,
)
from GaudiConf import IOHelper
from PRConfig.TestFileDB import test_file_db

ioh = IOHelper()
ioh.setupServices()
ioh.outStream("PFN:LHCbApp_CopyInputStream.dst", "CopyInputStream")

app = LHCbApp(EvtMax=10)
appMgr = ApplicationMgr()
appMgr.TopAlg = [FetchLeavesFromFile()]

test_file_db["upgrade_minbias_hlt1_filtered"].run(configurable=app)

This can be a single test. I don't think there's a need for a reference file here, as the information there is already tested in Gaudi.

added 1 commit

• 6c62a264 - remove redundant IO tests and add LHCb-specific test

Compare with previous version

added 1 commit

• 1c4fb39a - Fixed formatting

Compare with previous version

added 1 commit

• 68bfa0af - add lhcb copyright

Compare with previous version

changed the description

unmarked as a Work In Progress

changed title from WIP: QMTests of NewInputCopyStream to QMTest of CopyInputStream

marked as a Work In Progress

unmarked as a Work In Progress

Do I need to add some labels so that this merge request can be tested in the nightly build? The corresponding Gaudi merge request has been merged into master.

assigned to @abrearod

added needs Gaudi release label

added 1 commit

• 1f4d170e - clean up refs

Compare with previous version

added 1 commit

• 72a3683b - clean up refs

Compare with previous version

approved this merge request

/ci-test --merge

• [2020-07-24 10:38] Validation started with lhcb-master-mr#1109
• [2020-07-29 00:06] Validation started with lhcb-sanitizers#637
• [2020-07-29 00:09] Validation started with lhcb-lcg-dev3#1343
• [2020-07-29 00:09] Validation started with lhcb-gaussino#774
• [2020-07-29 00:10] Validation started with lhcb-lcg-dev4#1358
• [2020-07-29 00:10] Validation started with lhcb-new-cmake#145
• [2020-07-29 00:11] Validation started with lhcb-gauss-dev#2463
• [2020-07-29 00:11] Validation started with lhcb-test-efficiency#142
• [2020-07-29 00:15] Validation started with lhcb-dd4hep#599
• [2020-07-29 00:18] Validation started with lhcb-gaudi-head#2679
• [2020-07-29 00:20] Validation started with lhcb-gaudi-head-py3#430
• [2020-07-29 00:23] Validation started with lhcb-head#2665
• [2020-07-30 00:05] Validation started with lhcb-lcg-dev4#1359
• [2020-07-30 00:06] Validation started with lhcb-sanitizers#638
• [2020-07-30 00:07] Validation started with lhcb-lcg-dev3#1344
• [2020-07-30 00:07] Validation started with lhcb-gauss-dev#2464
• [2020-07-30 00:09] Validation started with lhcb-gaussino#775
• [2020-07-30 00:10] Validation started with lhcb-test-efficiency#143
• [2020-07-30 00:13] Validation started with lhcb-gaudi-head-py3#431
• [2020-07-30 00:22] Validation started with lhcb-new-cmake#146
• [2020-07-30 00:24] Validation started with lhcb-dd4hep#600
• [2020-07-30 00:26] Validation started with lhcb-gaudi-head#2680
• [2020-07-30 00:38] Validation started with lhcb-head#2666
• [2020-07-30 12:45] Validation started with lhcb-dd4hep#601
• [2020-07-30 14:58] Validation started with lhcb-dd4hep#602
• [2020-07-30 15:34] Validation started with lhcb-dd4hep#603
• [2020-07-30 16:24] Validation started with lhcb-dd4hep#604
• [2020-07-31 00:05] Validation started with lhcb-gaussino#776
• [2020-07-31 00:06] Validation started with lhcb-lcg-dev4#1360
• [2020-07-31 00:07] Validation started with lhcb-gauss-dev#2465
• [2020-07-31 00:08] Validation started with lhcb-lcg-dev3#1345
• [2020-07-31 00:09] Validation started with lhcb-sanitizers#639
• [2020-07-31 00:10] Validation started with lhcb-test-efficiency#144
• [2020-07-31 00:15] Validation started with lhcb-dd4hep#605
• [2020-07-31 00:16] Validation started with lhcb-gaudi-head-py3#432
• [2020-07-31 00:19] Validation started with lhcb-new-cmake#147
• [2020-07-31 00:19] Validation started with lhcb-head#2667
• [2020-07-31 00:28] Validation started with lhcb-gaudi-head#2681
• [2020-08-01 00:06] Validation started with lhcb-gaussino#777
• [2020-08-01 00:06] Validation started with lhcb-lcg-dev3#1346
• [2020-08-01 00:06] Validation started with lhcb-sanitizers#640
• [2020-08-01 00:07] Validation started with lhcb-test-efficiency#145
• [2020-08-01 00:08] Validation started with lhcb-lcg-dev4#1361
• [2020-08-01 00:09] Validation started with lhcb-gaudi-head-py3#433
• [2020-08-01 00:10] Validation started with lhcb-gauss-dev#2466
• [2020-08-01 00:10] Validation started with lhcb-new-cmake#148
• [2020-08-01 00:11] Validation started with lhcb-head#2668
• [2020-08-01 00:18] Validation started with lhcb-dd4hep#606
• [2020-08-01 00:38] Validation started with lhcb-gaudi-head#2682
• [2020-08-02 00:04] Validation started with lhcb-gaudi-head-py3#434
• [2020-08-02 00:04] Validation started with lhcb-lcg-dev4#1362
• [2020-08-02 00:05] Validation started with lhcb-sanitizers#641
• [2020-08-02 00:06] Validation started with lhcb-gaudi-head#2683
• [2020-08-02 00:08] Validation started with lhcb-head#2669
• [2020-08-02 00:08] Validation started with lhcb-new-cmake#149
• [2020-08-02 00:09] Validation started with lhcb-lcg-dev3#1347
• [2020-08-02 00:09] Validation started with lhcb-gauss-dev#2467
• [2020-08-02 00:29] Validation started with lhcb-coverity#518
• [2020-08-03 00:05] Validation started with lhcb-lcg-dev4#1363
• [2020-08-03 00:08] Validation started with lhcb-lcg-dev3#1348
• [2020-08-03 00:10] Validation started with lhcb-gauss-dev#2468
• [2020-08-03 00:12] Validation started with lhcb-head#2670
• [2020-08-04 00:06] Validation started with lhcb-lcg-dev4#1364
• [2020-08-04 00:06] Validation started with lhcb-dd4hep#607
• [2020-08-04 00:07] Validation started with lhcb-gaudi-head#2684
• [2020-08-04 00:08] Validation started with lhcb-new-cmake#150
• [2020-08-04 00:08] Validation started with lhcb-sanitizers#642
• [2020-08-04 00:09] Validation started with lhcb-gaudi-head-py3#435
• [2020-08-04 00:10] Validation started with lhcb-gauss-dev#2469
• [2020-08-04 00:10] Validation started with lhcb-test-efficiency#146
• [2020-08-04 00:11] Validation started with lhcb-lcg-dev3#1349
• [2020-08-04 00:12] Validation started with lhcb-head#2671
• [2020-08-04 00:48] Validation started with lhcb-gaudi-head#2684
• [2020-08-05 00:06] Validation started with lhcb-lcg-dev4#1365
• [2020-08-05 00:09] Validation started with lhcb-gaussino#779
• [2020-08-05 00:09] Validation started with lhcb-test-efficiency#147
• [2020-08-05 00:09] Validation started with lhcb-lcg-dev3#1350
• [2020-08-05 00:10] Validation started with lhcb-gauss-dev#2470
• [2020-08-05 00:10] Validation started with lhcb-new-cmake#151
• [2020-08-05 00:11] Validation started with lhcb-dd4hep#608
• [2020-08-05 00:13] Validation started with lhcb-gaudi-head-py3#436
• [2020-08-05 00:13] Validation started with lhcb-gaudi-head#2685
• [2020-08-05 00:15] Validation started with lhcb-head#2672

The validation looks good to me.

I see an unexpected wrong counters error in the last Moore test @axu

Test looks nice, Moore error can be ignored (@jonrob )

assigned to @jonrob and unassigned @abrearod

added all-slots label

Can this be merged now the Gaudi MR is in master, or does it as the label says really need a release of Gaudi first with the change there ?

mentioned in issue Moore#200 (closed)

assigned to @dcampora

@dcampora Note this should remain open into the new Gaudi release based on LCG97a is out.

unassigned @jonrob

removed needs Gaudi release label

/ci-test --merge

• [2020-08-05 15:31] Validation started with lhcb-master-mr#1156
• [2020-08-06 00:05] Validation started with lhcb-gaussino#780
• [2020-08-06 00:09] Validation started with lhcb-test-efficiency#148
• [2020-08-06 00:10] Validation started with lhcb-lcg-dev3#1351
• [2020-08-06 00:10] Validation started with lhcb-new-cmake#152
• [2020-08-06 00:10] Validation started with lhcb-lcg-dev4#1366
• [2020-08-06 00:11] Validation started with lhcb-dd4hep#609
• [2020-08-06 00:12] Validation started with lhcb-gauss-dev#2471
• [2020-08-06 00:12] Validation started with lhcb-gaudi-head#2686
• [2020-08-06 00:13] Validation started with lhcb-gaudi-head-py3#437
• [2020-08-06 00:13] Validation started with lhcb-sanitizers#644
• [2020-08-06 00:16] Validation started with lhcb-head#2673

approved this merge request

unassigned @dcampora

resolved all threads

merged

mentioned in commit fa1cbf2f

mentioned in issue Moore#203 (closed)

added Core testing labels and removed all-slots label

picked the changes into the branch cherry-pick-fa1cbf2f with commit 91696cbc

mentioned in commit 91696cbc

mentioned in merge request !2710 (merged)