Implement math for 2D measurements

To deal with the projection and filtering of 2D measurements in Rec, the corresponding math (Filter, Similarity transforms) for 2x5 projection matrices is implemented in the LHCb math kernel.

To match interface calls in Rec, this MR should be considered in line with Rec!2485 (merged) and Alignment!205 (merged)

mentioned in merge request Rec!2140 (merged)

changed the description

added 1 commit

• 6174cbfb - tested 2D measurements, corrected many 2D filter aspects. Now has comparable...

Compare with previous version

Where are we with this ? Is it ready to test ?

I think so, the filtering is functional. An update from the wishlist (on Rec!2140 (merged)) for a simpler implementation removing all the multiplications with 0 in the projection matrix is still expected in the coming days.

(note that the implementation of TrackProjectionMatrix as an std::variant will break things in the FitNode class in Rec if not considered simultaneously with Rec!2140 (merged)).

added 499 commits

• 6174cbfb...497e2a2a - 496 commits from branch master
• 05b9adbf - added Filter for 2D measurements
• 0056be5f - added similarity transforms and filters for 2D measurements
• f3479158 - tested 2D measurements, corrected many 2D filter aspects. Now has comparable...

Compare with previous version

Ok, I'll wait that Rec!2140 (merged) is also ready (there has been quite a number of comments there) and test both.

added 299 commits

• f3479158...9b92ad30 - 296 commits from branch master
• 2ad53aa8 - added Filter for 2D measurements
• 5b09d646 - added similarity transforms and filters for 2D measurements
• 867d48b0 - tested 2D measurements, corrected many 2D filter aspects. Now has comparable...

Compare with previous version

resolved all threads

added 2 commits

• 3fce296e - changed trackprojectionmatrix back to non-variant type
• 185fea56 - added faster version of 2D filter for vp2d measurements

Compare with previous version

also, please fix the formatting so that the ci pipeline passes...

added 1 commit

• 06f4046f - started changes for generic N-D measurements. DOES NOT COMPILE.

Compare with previous version

added 119 commits

• 06f4046f...1e76fe04 - 114 commits from branch master
• 85f9c536 - added Filter for 2D measurements
• 764fd4ea - added similarity transforms and filters for 2D measurements
• 21c7bc21 - tested 2D measurements, corrected many 2D filter aspects. Now has comparable...
• 6d875b30 - changed trackprojectionmatrix back to non-variant type
• c0f860df - added faster version of 2D filter for vp2d measurements

Compare with previous version

added 7 commits

• fa77295b - added Filter for 2D measurements
• 8aa82d27 - added similarity transforms and filters for 2D measurements
• 223a1f3b - tested 2D measurements, corrected many 2D filter aspects. Now has comparable...
• b76234e6 - changed trackprojectionmatrix back to non-variant type
• 2e755bbd - added faster version of 2D filter for vp2d measurements
• 5d24ff8d - started changes for generic N-D measurements. DOES NOT COMPILE.
• a28bf1e1 - fix formatting

Compare with previous version

added 1 commit

• bbe6d6b2 - fix compilation problems

Compare with previous version

added 1 commit

• 71ab1f4c - fix compilation problems

Compare with previous version

added 1 commit

• 916d55a7 - fix compilation problems

Compare with previous version

added 1 commit

• 888cd202 - fix compilation problems

Compare with previous version

added 1 commit

• 93fc372d - fix compilation problems

Compare with previous version

added 1 commit

• c657cab7 - fix compilation problems

Compare with previous version

added 1 commit

• aaefcebb - fix compilation problems

Compare with previous version

added 1 commit

• 851eddb2 - fix compilation problems

Compare with previous version

added 1 commit

• cc211aed - fix compilation problems

Compare with previous version

mentioned in merge request Rec!2390 (merged)

added 58 commits

• cc211aed...7c054c85 - 49 commits from branch master
• c3f4b2a1 - added Filter for 2D measurements
• 58734edb - added similarity transforms and filters for 2D measurements
• ca0b7114 - tested 2D measurements, corrected many 2D filter aspects. Now has comparable...
• 876a6132 - changed trackprojectionmatrix back to non-variant type
• 2c941ba4 - added faster version of 2D filter for vp2d measurements
• 51ab9aea - started changes for generic N-D measurements. DOES NOT COMPILE.
• 57715052 - fix formatting
• 8c3c9532 - fix compilation problems
• 0e6fcfae - Minor change to filter interface inline

Compare with previous version

added 1 commit

• 1872a89a - updated similarity for 2x2 errResiduals

Compare with previous version

added 81 commits

• 1872a89a...3d21d92d - 71 commits from branch master
• 2948336d - added Filter for 2D measurements
• 37690a6b - added similarity transforms and filters for 2D measurements
• 16869390 - tested 2D measurements, corrected many 2D filter aspects. Now has comparable...
• 1d4c3324 - changed trackprojectionmatrix back to non-variant type
• 7bf25a6f - added faster version of 2D filter for vp2d measurements
• fb22deea - started changes for generic N-D measurements. DOES NOT COMPILE.
• 4936289e - fix formatting
• f2cdaca8 - fix compilation problems
• 7322e7f9 - Minor change to filter interface inline
• 2e674d41 - updated similarity for 2x2 errResiduals

Compare with previous version

added 134 commits

• 2e674d41...cfa13485 - 123 commits from branch master
• c57afdc8 - added Filter for 2D measurements
• 5d20548b - added similarity transforms and filters for 2D measurements
• e4666b0e - tested 2D measurements, corrected many 2D filter aspects. Now has comparable...
• c8ead542 - changed trackprojectionmatrix back to non-variant type
• 6e281e75 - added faster version of 2D filter for vp2d measurements
• 3bcaad1c - started changes for generic N-D measurements. DOES NOT COMPILE.
• 46e9af7a - fix formatting
• 5b57bdbd - fix compilation problems
• 67ce9c2c - Minor change to filter interface inline
• d2e734b0 - updated similarity for 2x2 errResiduals
• baf5ebf5 - minor changs to Similarity interface

Compare with previous version

mentioned in merge request Rec!2485 (merged)

changed the description

added 1 commit

• cdda537c - Fixed formatting

Compare with previous version

marked this merge request as ready

mentioned in merge request gaudi/Gaudi!1232 (merged)

added 1 commit

• 420d609c - minor modifications following MR comments

Compare with previous version

added 1 commit

• 6bd47748 - added tests for new similarity and filter

Compare with previous version

added 1 commit

• 63aab6f3 - Fixed formatting

Compare with previous version

added 1 commit

• 679afa85 - added chosen values tests for 2D filter

Compare with previous version

resolved all threads

added 1 commit

• 3b9205fd - Fixed formatting

Compare with previous version

added 19 commits

• 3b9205fd...747e13b3 - 2 commits from branch master
• 9a594c34 - added Filter for 2D measurements
• 14b3c438 - added similarity transforms and filters for 2D measurements
• 05cb1a41 - tested 2D measurements, corrected many 2D filter aspects. Now has comparable...
• dfbbdb03 - changed trackprojectionmatrix back to non-variant type
• 04c729db - added faster version of 2D filter for vp2d measurements
• 01515235 - started changes for generic N-D measurements. DOES NOT COMPILE.
• f9f2a9b0 - fix formatting
• f98940d8 - fix compilation problems
• 225bd92b - Minor change to filter interface inline
• dd594204 - updated similarity for 2x2 errResiduals
• ed765990 - minor changs to Similarity interface
• 49eda42e - Fixed formatting
• 471f0efa - minor modifications following MR comments
• f496c132 - added tests for new similarity and filter
• 233a2b3d - Fixed formatting
• e2da3b5f - added chosen values tests for 2D filter
• e848db7a - Fixed formatting

Compare with previous version

added 1 commit

• 70a1d1a3 - Fixed formatting

Compare with previous version

added 1 commit

• 7da8fb83 - added warning for 2D case not being fully tested

Compare with previous version

resolved all threads

added 1 commit

• 39198325 - Fixed formatting

Compare with previous version

perhaps this is a good moment to repeat @sponce's question from December 2nd:

Where are we with this ? Is it ready to test ?

to which @jadevrie answered on December 3rd :

I think so

added 122 commits

• 39198325...df82b994 - 103 commits from branch master
• 5ee552a9 - added Filter for 2D measurements
• c41e689e - added similarity transforms and filters for 2D measurements
• 7a391aba - tested 2D measurements, corrected many 2D filter aspects. Now has comparable...
• b54a0c21 - changed trackprojectionmatrix back to non-variant type
• 8e8d4a6c - added faster version of 2D filter for vp2d measurements
• c64c2481 - started changes for generic N-D measurements. DOES NOT COMPILE.
• 8842bc5b - fix formatting
• ac61f50e - fix compilation problems
• 9fd5521d - Minor change to filter interface inline
• 8b62a848 - updated similarity for 2x2 errResiduals
• 4567394e - minor changs to Similarity interface
• adb238c7 - Fixed formatting
• 5e558ce9 - minor modifications following MR comments
• bd778961 - added tests for new similarity and filter
• 7dc454d5 - Fixed formatting
• 1f73ed98 - added chosen values tests for 2D filter
• eb91ea55 - Fixed formatting
• cb9b9776 - added warning for 2D case not being fully tested
• 32a3a80e - Fixed formatting

Compare with previous version

resolved all threads

assigned to @rangel

@jadevrie what is the status of this MR? Is this ready to be merged? May you add label(s) to it? (same comment for Rec!2485 (merged))

Ready to be merged, will add labels.

added Filters Tracking labels

/ci-test --merge Rec!2485 (merged)

added ci-test-triggered label

• [2021-08-20 11:51] Validation started with lhcb-master-mr#2741
• [2021-08-21 20:11] Validation started with lhcb-master-mr#2750

assigned to @jadevrie and unassigned @rangel

mentioned in merge request Alignment!205 (merged)

changed the description

assigned to @rangel and unassigned @jadevrie

added 1 commit

• bf9a78ce - Apply 3 suggestion(s) to 2 file(s)

Compare with previous version

added 46 commits

• bf9a78ce...2dbb0052 - 26 commits from branch master
• e6a0e935 - added Filter for 2D measurements
• 352f8d7d - added similarity transforms and filters for 2D measurements
• 08665e1c - tested 2D measurements, corrected many 2D filter aspects. Now has comparable...
• 0448e3c7 - changed trackprojectionmatrix back to non-variant type
• eb903399 - added faster version of 2D filter for vp2d measurements
• df67f8ce - started changes for generic N-D measurements. DOES NOT COMPILE.
• 357d49db - fix formatting
• cdebc5d0 - fix compilation problems
• a96e0bae - Minor change to filter interface inline
• 94df5c14 - updated similarity for 2x2 errResiduals
• 03a969c2 - minor changs to Similarity interface
• 0a01c108 - Fixed formatting
• 31e672e6 - minor modifications following MR comments
• cdb46ee3 - added tests for new similarity and filter
• 03ab8134 - Fixed formatting
• 4bf783bb - added chosen values tests for 2D filter
• 4e78c0e9 - Fixed formatting
• 944d5a4f - added warning for 2D case not being fully tested
• 85c6611e - Fixed formatting
• e4b378e3 - Merge branch 'track-fit-workshop-jadevrie' of...

Compare with previous version

added 1 commit

• a5110fe9 - re-added 2D filter test

Compare with previous version

added 1 commit

• 3a33c6a5 - Fixed formatting

Compare with previous version

resolved all threads

/ci-test --merge Rec!2485 (merged) Alignment!205 (merged)

• [2021-08-27 14:47] Validation started with lhcb-master-mr#2785
• [2021-09-01 10:39] Validation started with lhcb-master-mr#2807

mentioned in issue Moore#313 (closed)

assigned to @chasse and unassigned @rangel

added 1 commit

• 88910a1b - added SMatrix eval in new file ROOTExensions.h

Compare with previous version