Modernize deterministic mixer code
1 unresolved thread
1 unresolved thread
- replace uint32_t state and free functions with a small struct
- define a single overload set for mixing
- be paranoid about implicit conversions of the 'extra' state
- use the above mentioned struct everywhere, and remove copies of the code
- add a unit test (which contains a copy of the original code to verify the results are the same)
- replace use of
boost::integer_traits
withstd::numeric_limits
Edited by Gerhard Raven
Merge request reports
Activity
Filter activity
added cleanup modernisation labels
added ci-test-triggered label
- [2020-10-03 00:42] Validation started with lhcb-master-mr#1400
- [2020-10-03 17:24] Validation started with lhcb-master-mr#1403
Edited by Software for LHCbadded 1 commit
- f8765a37 - Move DeterministicMixer to LHCbMath, re-use in LoKiHlt
added 1 commit
- 28d10c8a - Move DeterministicMixer to LHCbMath, re-use in LoKiHlt
added 1 commit
- a6bc2758 - Move DeterministicMixer to LHCbMath, re-use in LoKiHlt
added 1 commit
- a3d106fb - Move DeterministicMixer to LHCbMath, re-use in LoKiHlt
added 1 commit
- afa02aea - prefer std::numeric_limits over boost::integer_traits
assigned to @ascarabo
added 2 commits
assigned to @ascarabo
added 6 commits
-
363f65e1...b862fdb8 - 2 commits from branch
master
- 215be9db - Modernize deterministic mixer code
- aedec86c - Move DeterministicMixer to LHCbMath, re-use in LoKiHlt
- 9c53e9e3 - prefer std::numeric_limits over boost::integer_traits
- dc3a3248 - add unit test
Toggle commit list-
363f65e1...b862fdb8 - 2 commits from branch
- [2020-10-04 12:57] Automatic merge failed in lhcb-master-mr#1404
- [2020-10-04 19:33] Validation started with lhcb-master-mr#1405
- [2020-10-05 09:24] Validation started with lhcb-master-mr#1407
Edited by Software for LHCbunassigned @graven
assigned to @raaij
mentioned in issue Moore#213 (closed)
mentioned in commit 94f8e5a4
@graven, this doesn't seem to work with the latest gsl. See http://lhcb-nightlies.web.cern.ch/logs/build/nightly/lhcb-lcg-dev4/1428/x86_64-centos7-gcc9-opt/LHCb/#show_Kernel_LHCbMath/Kernel_LHCbMath_128
see !2796 (merged)
added Core label
Please register or sign in to reply