Made (Un)PackCaloHypo half way functional
Goes with Rec!2266 (merged), Moore!666 (merged) and DaVinci!474 (merged)
To be precise PackCaloHypo is functional for its output, but not for its input. This would need producers of the input to be functional too. Left for next round.
Also cleans up the interface ClusterFromHypo, using references rather than pointers
Merge request reports
Activity
mentioned in merge request Rec!2266 (merged)
assigned to @msaur
- Resolved by Sebastien Ponce
/ci-test --merge Rec!2266 (merged)
added ci-test-triggered label
- [2020-11-11 17:09] Validation started with lhcb-master-mr#1558
- Resolved by Sebastien Ponce
I guess we're already aware of this, but to be explicit: it's tricky thinking about the current unpackers in a truly "functional" way because the unpacked objects hold
SmartRef
objects. This makes for an implicit data dependency; one doesn't need the dependency to run the unpacking, but the dependency is needed to read the unpacked data fully.I've been trying to put all of this type of information in one of our vision pages. I don't have much to say about Gaudi functional there atm, but would appreciate your input. (Doesn't need to hold up this MR, we can discuss as an issue in that repo or something).
mentioned in merge request Moore!646 (merged)
mentioned in merge request Moore!666 (merged)
- Resolved by Sebastien Ponce
/ci-test --merge Rec!2266 (merged) Moore!666 (merged)
assigned to @sponce
- [2020-11-13 15:13] Validation started with lhcb-master-mr#1572
- [2020-11-16 16:43] Validation started with lhcb-master-mr#1582
Edited by Software for LHCb- Resolved by Sebastien Ponce