Add a Generic Track SOA Container
Implementation of v2 Track container mentioned to #97 (closed) , here named as Generic Tracks. Implements storage of full state covariance information, multiple states per track, and and storage of LHCbID's by subdetector. Currently, an exception is thrown when a state that is undefined for a certain track type is accessed. Associated with Rec!2356 (merged) and Phys!882 (merged) @mramospe @mvesteri @apearce
Merge request reports
Activity
- Resolved by Alexander Leon Gilman
fyi == it is in a state where somebody should have a look?
- Resolved by Miguel Ramos Pernas
@agilman, something I forgot to mention is that in LHCb there is a convention on how to format the code (both for
C++
andpython
). There is a command calledlb-format
that, given a list of files, applies the format in-place. You can call something likelb-format $(find . -name "*.py") $(find . -name "*.cpp") $(find . -name "*.h")
to format everything in the current folder (it may turn time consuming, so consider formatting only the new/modified files). The current pipeline is failing because the format is wrong. Also, no check is currently done to determine if the current branch compiles correctly and that there are no conflicts with other parts of the software (also cross-project and cross-platform). This is done once we mark everything as ready and/or once we set some labels in the merge request description.
added 1 commit
- 3d583b60 - max number of LHCbID's updated in accordance with PrLongTracks.h. Added more comments to v2 tracks.
@nnolte we have been discussing today that we might need to use track converters in order to test this new track object. Is there anything that we could use straight away, or should we define a converter like in https://gitlab.cern.ch/lhcb/Rec/-/blob/master/Pr/PrConverters/src/fromV2TrackV1Track.cpp?
added 1 commit
- e51a1f56 - Track type now set at runtime and at container level in v2Tracks
added 1 commit
- b9e17d27 - Added LHCbIDs by subdetector and getters for LHCbIDs
added 1 commit
- f59d7c39 - Tracks named to generic and altered state storage
added 1 commit
- 240376d0 - Replaced Particle_v2 with PrGenericTracks instead of PrFittedTracks
added 1 commit
- 41fc55b2 - Move functions to convert the tracks from Rec to LHCb
added RTA WP3 label