Remove CaloDAQ

Remove CaloDataProviderFromTES, discussed in https://gitlab.cern.ch/lhcb-dpa/project/-/issues/8 Remove Calo/CaloDAQ Needs some other changes in :

• Rec!2930 (merged)
• Lbcom!614 (merged)
• Phys!949 (merged) (now merged)
• Rec!2458 (closed) : Add digit v2 to v1 converter, linked to changes in Lbcom and Boole, see next lines
• Lbcom!561 (closed) : Changes in CaloDigitMCTruth and CaloReCreateMCLinks
• Boole!341 (closed)

added Calo label

added lhcb-run3-cleanup label

Can we go one step further? it looks like the ICaloDataProvider is not used at all - if so, then it and the other implementations of it can be removed as well. One thing to note is that ICaloGetterTool uses ICaloDataProvider, but there is no implementation of ICaloGetter. So the one bit of code which uses ICaloGetter (VeloCaloBuilder in Rec) cannot actually configure at runtime, and hence it is never actually used, so it can be removed as well...

To go even further, CaloDAQ is not used for run 3 (was originally kept for backward compatibility) everything should be in CaloFutureDAQ now. This is part of the CaloFuture-->Calo cleanup we would like to do but may be we can anticipate and remove it now?

added 1 commit

• 411d0de3 - Remove Calo/CaloDAQ

Compare with previous version

changed title from WIP: Remove CaloDataProviderFromTES to WIP: Remove CaloDAQ

changed the description

mentioned in merge request Rec!2375 (closed)

• [2021-03-18 01:20] Validation started with lhcb-run3-cleanup#167
• [2021-03-19 01:14] Validation started with lhcb-run3-cleanup#168
• [2021-03-20 01:19] Validation started with lhcb-run3-cleanup#169
• [2021-03-23 00:33] Automatic merge failed in lhcb-run3-cleanup#170
• [2021-03-24 01:03] Automatic merge failed in lhcb-run3-cleanup#171
• [2021-03-25 01:15] Automatic merge failed in lhcb-run3-cleanup#172
• [2021-03-26 00:52] Automatic merge failed in lhcb-run3-cleanup#173
• [2021-03-27 01:01] Automatic merge failed in lhcb-run3-cleanup#174
• [2021-03-29 00:38] Automatic merge failed in lhcb-run3-cleanup#175
• [2021-03-30 00:37] Automatic merge failed in lhcb-run3-cleanup#176
• [2021-03-31 00:59] Automatic merge failed in lhcb-run3-cleanup#177
• [2021-04-01 01:38] Automatic merge failed in lhcb-run3-cleanup#178
• [2021-04-02 00:50] Automatic merge failed in lhcb-run3-cleanup#179
• [2021-04-07 00:46] Automatic merge failed in lhcb-run3-cleanup#180
• [2021-04-08 00:53] Automatic merge failed in lhcb-run3-cleanup#181
• [2021-04-09 01:03] Automatic merge failed in lhcb-run3-cleanup#182
• [2021-04-10 00:58] Automatic merge failed in lhcb-run3-cleanup#183
• [2021-04-13 00:41] Automatic merge failed in lhcb-run3-cleanup#184
• [2021-04-14 00:55] Automatic merge failed in lhcb-run3-cleanup#185
• [2021-04-15 01:18] Automatic merge failed in lhcb-run3-cleanup#186
• [2021-04-16 01:15] Automatic merge failed in lhcb-run3-cleanup#187
• [2021-04-17 01:21] Automatic merge failed in lhcb-run3-cleanup#188
• [2021-04-19 01:06] Automatic merge failed in lhcb-run3-cleanup#189
• [2021-04-20 00:54] Automatic merge failed in lhcb-run3-cleanup#190
• [2021-04-21 01:19] Automatic merge failed in lhcb-run3-cleanup#191
• [2021-04-22 00:58] Automatic merge failed in [lhcb-run3-cleanup#192](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/192/LHCb/checkout
• [2021-04-23 01:22] Automatic merge failed in [lhcb-run3-cleanup#193](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/193/LHCb/checkout
• [2021-04-24 01:36] Automatic merge failed in [lhcb-run3-cleanup#194](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/194/LHCb/checkout
• [2021-04-26 00:50] Automatic merge failed in [lhcb-run3-cleanup#195](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/195/LHCb/checkout
• [2021-04-27 01:10] Automatic merge failed in [lhcb-run3-cleanup#196](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/196/LHCb/checkout
• [2021-04-28 01:13] Automatic merge failed in [lhcb-run3-cleanup#197](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/197/LHCb/checkout
• [2021-04-29 01:28] Automatic merge failed in [lhcb-run3-cleanup#198](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/198/LHCb/checkout
• [2021-04-30 01:27] Automatic merge failed in [lhcb-run3-cleanup#199](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/199/LHCb/checkout
• [2021-05-01 01:24] Automatic merge failed in [lhcb-run3-cleanup#200](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/200/LHCb/checkout
• [2021-05-04 00:28] Automatic merge failed in [lhcb-run3-cleanup#201](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/201/LHCb/checkout
• [2021-05-05 00:42] Automatic merge failed in [lhcb-run3-cleanup#202](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/202/LHCb/checkout
• [2021-05-06 00:40] Automatic merge failed in [lhcb-run3-cleanup#203](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/203/LHCb/checkout
• [2021-05-07 00:48] Automatic merge failed in [lhcb-run3-cleanup#204](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/204/LHCb/checkout
• [2021-05-08 01:02] Automatic merge failed in [lhcb-run3-cleanup#205](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/205/LHCb/checkout
• [2021-05-10 00:10] Automatic merge failed in [lhcb-run3-cleanup#206](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/206/LHCb/checkout
• [2021-05-11 00:40] Automatic merge failed in [lhcb-run3-cleanup#207](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/207/LHCb/checkout
• [2021-05-12 01:01] Automatic merge failed in [lhcb-run3-cleanup#208](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/208/LHCb/checkout
• [2021-05-13 00:58] Automatic merge failed in [lhcb-run3-cleanup#209](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/209/LHCb/checkout
• [2021-05-14 01:12] Automatic merge failed in [lhcb-run3-cleanup#210](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/210/LHCb/checkout
• [2021-05-16 00:27] Automatic merge failed in [lhcb-run3-cleanup#211](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/211/LHCb/checkout
• [2021-05-18 01:04] Automatic merge failed in [lhcb-run3-cleanup#212](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/212/LHCb/checkout
• [2021-05-19 00:47] Automatic merge failed in [lhcb-run3-cleanup#213](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/213/LHCb/checkout
• [2021-05-20 01:06] Automatic merge failed in [lhcb-run3-cleanup#214](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/214/LHCb/checkout
• [2021-05-21 01:20] Automatic merge failed in [lhcb-run3-cleanup#215](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/215/LHCb/checkout
• [2021-05-22 01:22] Automatic merge failed in [lhcb-run3-cleanup#216](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/216/LHCb/checkout
• [2021-05-25 00:43] Automatic merge failed in [lhcb-run3-cleanup#217](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/217/LHCb/checkout
• [2021-05-26 01:16] Automatic merge failed in [lhcb-run3-cleanup#218](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/218/LHCb/checkout
• [2021-05-27 01:11] Automatic merge failed in [lhcb-run3-cleanup#219](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/219/LHCb/checkout
• [2021-05-28 01:26] Automatic merge failed in [lhcb-run3-cleanup#220](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-run3-cleanup/220/LHCb/checkout
• [2021-05-29 01:39] Validation started with lhcb-run3-cleanup#221
• [2021-05-30 00:37] Validation started with lhcb-run3-cleanup#222
• [2021-05-30 00:44] Validation started with lhcb-run3-cleanup#222
• [2021-05-31 00:29] Validation started with lhcb-run3-cleanup#223

added 1 commit

• fc3ce7cb - Revert CaloDAQ delete

Compare with previous version

added 1 commit

• 9317e6c9 - Revert CaloDAQ delete

Compare with previous version

added 1 commit

• d1844f0d - Revert CaloDAQ delete

Compare with previous version

CaloDAQ isn't used for the reco but more work is needed on Boole side so I reintegrated it for the moment.

closed

reopened

Just my 2 cents but I think you should keep the code removed while working out to sort things out in Boole. Isn't that the reason to state "WIP" above? If you lb-glimpse you will easily see where the files removed here are called ... And if that's no longer needed for run-3 the fixes (basically removals) should be easy IMO.

The "easy" fix would be to move CaloDAQ to Boole, but that worries me a lot, it means we have a divergence between the encoders in Boole and the decoders in RTA/DPA. In any case, looking at the validation nightly, there are other things to be fixed, in LHCb, Phys, Moore, DaVinci

Indeed. A lot has to do with CommonParticles, which is something to be removed at some stage, anyway. We are now in March and we need to be a bit more "aggressive". For example some of the errors come from trying to import "tight electrons", which for sure nobody will be pulling out as-is in run-3 DaVinci; just get rid of it and that will likely deal with a large fraction of the errors. Likewise for some others.

I agree that "easy fixes" may raise other problems. Not a direction to take for code we know is superseded/obsolete.

added DPA-WP3 label