add support for TH3 reading from conditions DB

Adds TH3 support for use with CondDB. Needs Gaudi!1226 and needed for Rec!2319 (merged).

mentioned in merge request Rec!2319 (merged)

added 1 commit

• 19332f25 - minor fix

Compare with previous version

marked this merge request as ready

Wouldn't it be better to switch directly to new, thread safe, histograms ? That is using https://gitlab.cern.ch/gaudi/Gaudi/-/blob/master/GaudiKernel/include/Gaudi/Accumulators/Histogram.h#L449 rather than implementing TH3 that is kind of deprecated from scratch ? Unless of course the functionality is not the same (I'm not so much an expert here), but even in that case, one should think of extending the new histograms.

We should (have) start(ed) a campaign to replace old histograms with the new one, so it's a bit of a shame to no take the opportunity to directly do it here.

Having said that, contact me directly if you have troubles with new histos, as the first users noticed that the documentation at https://gitlab.cern.ch/gaudi/Gaudi/-/blob/master/GaudiKernel/include/Gaudi/Accumulators/Histogram.h#L339 is not entirely up to date. Indeed after the code review, few details have been changed (e.g. addition of a title, extra braces around definition of axes) and were not reflected there. It's on my todo list, but not yet done :-P

changed title from adding TH3 support to add support for TH3 reading from conditions DB

added 34 commits

• 19332f25...10d46459 - 33 commits from branch master
• ecb1f9ce - Merge remote-tracking branch 'origin/master' into mveghel-th3support

Compare with previous version

mentioned in merge request Moore!901 (merged)

added 1 commit

• efd96b82 - Apply 2 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit

• ac50e616 - cleaned up comments

Compare with previous version

resolved all threads

@mveghel what is the status of this MR? Can we move forward?

assigned to @mveghel

assigned to @rangel

unassigned @mveghel

Given that gaudi/Gaudi!1226 (merged) has been merged, I don't see any reason not to merge this ASAP.

/ci-test --merge

added ci-test-triggered label

• [2021-08-20 11:49] Validation started with lhcb-master-mr#2740

assigned to @chasse

resolved all threads

resolved all threads

added 1 commit

• aca0a18b - fixed comments in code

Compare with previous version

merged

mentioned in commit 108460da

mentioned in commit a97fbac6

mentioned in merge request !3207 (merged)

picked the changes into the branch cherry-pick-108460da with commit 4f391119

mentioned in commit 4f391119

mentioned in merge request !3208 (merged)

mentioned in commit 49a199f0

mentioned in issue Moore#313 (closed)

mentioned in merge request lhcb-conddb/SIMCOND!152 (merged)

mentioned in commit a9746bf6