Skip to content
Snippets Groups Projects

Make LHCb::HltPackedDataWriter thread-safe

Merged Lucas Meyer Garcia requested to merge th_safe_packed_writer into master

A single buffer was used during the serialisation process. When multiple threads were active, the same buffer buffer would be used simultaneously by them. The serialisation buffer (and other members) are now created for each event.

FYI: @sstahl @rmatev

Edited by Lucas Meyer Garcia

Merge request reports

Pipeline #2814929 passed

Pipeline passed for d8619703 on th_safe_packed_writer

Merged by Rosen MatevRosen Matev 3 years ago (Jul 20, 2021 7:41am UTC)

Merge details

  • Changes merged into with fb815659.
  • Deleted the source branch.

Pipeline #2841107 passed

Pipeline passed for fb815659 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks @lmeyerga ! Please mark this as ready after addressing the comments

  • assigned to @lmeyerga

  • added 3 commits

    • 9b175cce - Make saveObject() a standalone function.
    • e805fd22 - Use camelCase naming style.
    • 860e2f11 - Do not override GaudiAlgorithm::finalize().

    Compare with previous version

  • added 1 commit

    • 5cac2538 - Use function pointers instead of std:function in the CLID-function map. Move...

    Compare with previous version

  • Lucas Meyer Garcia resolved all threads

    resolved all threads

  • Lucas Meyer Garcia marked this merge request as ready

    marked this merge request as ready

  • Sascha Stahl
  • Sascha Stahl
  • added 1 commit

    • f962fd5f - WIP: Create histograms to monitor buffer sizes.

    Compare with previous version

  • Lucas Meyer Garcia marked this merge request as draft from f962fd5f

    marked this merge request as draft from f962fd5f

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading