Created an LHCb specific version of Functional base classes

The idea is to be able to customize them for LHCb if needed. The first customization leading to the creation of them is changing the default underlying Algorithm to Gaudi::Algorithm rather than GaudiAlgorithm

added Core enhancement labels

mentioned in commit 3f4a15fe

added 1 commit

• 82207def - Created an LHCb specific version of Functional base classes

Compare with previous version

added 1 commit

• 97418923 - Created an LHCb specific version of Functional base classes

Compare with previous version

assigned to @rangel

mentioned in merge request !3192 (merged)

Sorry to ask, isn't LHCb the only user of functional algorithms. So is this extra layer of abstraction necessary?

As mentioned in the title "to be able to customize them for LHCb" and especially "changing the default underlying Algorithm to Gaudi::Algorithm rather than GaudiAlgorithm". It avoids systematical usage of uses_BaseClass and more important forgetting it. More details in a comment by @graven here : 3f4a15fe (comment 4717939)

added 1 commit

• aa149fbb - Created an LHCb specific version of Functional base classes

Compare with previous version

resolved all threads

approved this merge request

@sponce is this MR ready to be merged?

I think it is, but as this code is completely unused after this MR, I would still wait for confirmation that !3192 (merged), which is the primary user of it for now, works well. I'll give you green light in the course of tomorrow.

thanks, I will unsign myself and once it makes sense to move FWD, assign it back to me.

unassigned @rangel

assigned to @rangel

@rangel I confirm it's working fine with !3192 (merged), so it can be merged.

added 2 commits

• 07f84a1d - Created an LHCb specific version of Functional base classes
• 2331d4a5 - Started to switch a number of classes to new LHCb functional base Algos

Compare with previous version

resolved all threads

added 1 commit

• f70ee95e - Started to switch a number of classes to new LHCb functional base Algos

Compare with previous version

/ci-test

added ci-test-triggered label

added 18 commits

• f70ee95e...93395887 - 16 commits from branch master
• 548b61cc - Created an LHCb specific version of Functional base classes
• 5e0afe61 - Started to switch a number of classes to new LHCb functional base Algos

Compare with previous version

/ci-test --merge

• [2021-08-19 17:59] Validation started with lhcb-master-mr#2737
• [2021-08-20 11:12] Validation started with lhcb-master-mr#2739

added 1 commit

• f22d9824 - Fixed clang compilation

Compare with previous version

/ci-test --merge

assigned to @chasse

resolved all threads

merged

mentioned in commit 23211bd6

mentioned in issue Moore#313 (closed)