Skip to content
Snippets Groups Projects

Align `PackedDataChecksum::process` code path with `save` code path

Merged Gerhard Raven requested to merge align-process-save into master
  • in PackedDataChecksum, re-use the save infrastructure to make sure that by construction the checksum is computed on exactly the same data that is actually saved as it now uses the same implementation
  • remove the as_tuple infrastructure which is no longer required

note: sits on top of !3244 (closed) which fixes a lifetime issue in as_tuple -- so where !3244 (closed) fixes a bug, this eliminates the code in question...

Edited by Gerhard Raven

Merge request reports

Pipeline #3012793 passed

Pipeline passed for 5f33c660 on align-process-save

Approval is optional

Merged by Christoph HasseChristoph Hasse 3 years ago (Sep 14, 2021 7:04am UTC)

Pipeline #3015126 passed

Pipeline passed for 5d26159b on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Gerhard Raven removed review request for @rmatev

    removed review request for @rmatev

  • Gerhard Raven added 1 commit

    added 1 commit

    Compare with previous version

  • assigned to @msaur

  • Christoph Hasse resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading