Remove implicit ordering assumption of LHCbIDs when converting to a v3::Track
Remove the implicit ordering assumption of LHCbIDs when converting a track to a v3::Track (which could lead to overwriting LHCbIDs on the created v3::Track).
Mildly connected to !3226 (merged)
Needs: Rec!2546 (merged)
Merge request reports
Activity
- Resolved by Christoph Hasse
Let's see if it affects anything...
/ci-test --merge --platforms=x86_64_v2-centos7-gcc10-opt
added ci-test-triggered label
- [2021-09-13 10:28] Validation started with lhcb-master-mr#2878
- [2021-09-13 14:36] Validation started with lhcb-master-mr#2881
Edited by Software for LHCb175 } 176 177 // are filled 178 if ( id.isUT() ) { 179 outTrack.template field<v3::Tag::LHCbIDs>( numVPLHCbIDs + numUTLHCbIDs ).set( id.lhcbID() ); 180 ++numUTLHCbIDs; 181 continue; 182 } 183 184 // Same comment as above, but between UT and FT id's 185 if ( id.isFT() ) { 186 outTrack.template field<v3::Tag::LHCbIDs>( numVPLHCbIDs + numUTLHCbIDs + numFTLHCbIDs ).set( id.lhcbID() ); 187 ++numFTLHCbIDs; 188 continue; 189 } 172 if ( id.isVelo() ) ++numVPLHCbIDs; - Resolved by Michel De Cian
added 1 commit
- 3fb941ac - Add assert to check consistency for sum of LHCbIDs
added 1 commit
- 01e1db5f - fix wrong check of LHCbID (Velo instead of VP) and add assert to make sure...
- Resolved by Christoph Hasse
- Resolved by Michel De Cian
Let's try again: /ci-test --merge --platforms=x86_64_v2-centos7-gcc10-opt
assigned to @msaur
- Resolved by Gerhard Raven
- Resolved by Michel De Cian
- Resolved by Christoph Hasse
@decianm Is this ready to be tested or some further development based on the discussion above is expected?
- Resolved by Christoph Hasse
/ci-test --merge
- [2021-09-14 14:37] Validation started with lhcb-master-mr#2888
- [2021-09-15 10:10] Validation started with lhcb-master-mr#2891
Edited by Software for LHCbmentioned in merge request Rec!2539 (merged)
mentioned in issue Rec#213 (closed)
added lhcb-head-2 label
- [2021-09-16 00:11] Validation started with lhcb-head-2#344
- [2021-09-16 17:23] Validation started with lhcb-master-mr#2903
Edited by Software for LHCbassigned to @chasse
removed lhcb-head-2 label
mentioned in merge request Rec!2546 (merged)
added needs ref update label
mentioned in commit Rec@fab0fa2c
mentioned in merge request Rec!2551 (merged)
- Resolved by Christoph Hasse
/ci-test --merge Rec!2551 (merged) Rec!2546 (merged)
mentioned in commit c5336fba
mentioned in commit Rec@9e0d0a1b
mentioned in issue Moore#324 (closed)