Spruce reports to RawBanks, further cleanup of HltDAQ
- Add SourceID for sprucing to allow sprucing-specific content in HltDecReports raw banks
- make mapping from SourceID -> {Hlt,TCK}ANNSvc major key bijective. As a result, support for run1-style 'joined' Hlt1/Hlt2 RawBank SourceID is removed. concretely: a one-to-one correspondence between the sourceID, and the list of decisions (obtained from the {Hlt,TCK}ANNSvc) that need to be decoded is now enforced.
- remove unused HltTrackReports{Writer,Decoder}
- factor out SourceID enum so a single definition can be shared
- add support for
Property<SourceID>and use that instead ofProperty<int>+ updatehandler or checks in initialize - given the above, decoder components no longer have include their corresponding writer header files
- amalgamate component header files into the corresponding source files
- migrate HltDiffHltDecReports to LHCb::Algorithm::Consumer
- make HltLumiWriter thread-safe
- prefer MsgCounter over Error(...) and Warning(...)
- prefer span over bare pointer
- start putting code in the LHCb::Hlt::DAQ namespace instead of
adding
using namespace LHCb
must be applied in conjunction with Moore!1003 (merged), DaVinci!578 (merged), Phys!989 (merged)
Addresses https://gitlab.cern.ch/lhcb-dpa/project/-/issues/153 for DPA
Merge request reports
Activity
added cleanup hlt1-throughput-decreased modernisation labels
removed hlt1-throughput-decreased label
- Resolved by Gerhard Raven
let's see how badly this fails:
/ci-test --merge --platforms=x86_64_v2-centos7-gcc10-opt
(could well be that due to the dropping of run1 compatibility and removal of HltTrackReports{Decoder,Writer} some tests will have to be revisited)
Edited by Gerhard Raven - Last reply by Gerhard Raven
added ci-test-triggered label
- [2021-09-20 16:41] Validation started with lhcb-master-mr#2916
- [2021-09-20 21:47] Validation started with lhcb-master-mr#2917
Edited by Software for LHCbmentioned in commit Moore@82071c76
mentioned in merge request Moore!1003 (merged)
- Resolved by Christoph Hasse
@nskidmor: given that this MR seems to be in better shape than I expected, could you see whether this is 'ok' for writing/reading the decreports from sprucing?
- Last reply by Nicole Skidmore
mentioned in commit DaVinci@af695817
