Skip to content
Snippets Groups Projects

First implementation of TELL40 v1 cluster output (default) and two sensor SP banks (only if FPGA clustering not available)

Merged David Hutchcroft requested to merge dhcroft-VPBankUpdate into master

Implement the v1 retina cluster format which is the default for first data taking, see https://edms.cern.ch/document/2086526/3 v.3 With the update requested by the RTA for the source ID to have the DF bit moved to the end, so bits 9..0 sort the order of the pairs of sensors.

The superpixel banks (not expected to be output, but could be if the clustering in the TELL40s is problematic) are mixed between two sensors and have the correct TFC routing bankID.

The VPRetinaCluster banks also contain two sensors worth of clusters using the v1 cluster bit patterns (previously v0 was implemented, see EDMS doc above). Note this is not fully checked, as it has not been run through Allen hence the Draft: label and includes all of the RCv1 updates recently accepted into master.

Note this is not backward compatible and will require MR Allen!874 (merged) in Allen to process the data.

This MR should be tested together with Allen!874 (merged), Boole!398 (merged), Rec!2958 (merged) and Moore!1635 (merged).

Edited by Giovanni Bassi

Merge request reports

Merge request pipeline #4282552 passed

Merge request pipeline passed for 682a5c8c

Approval is optional

Merged by Sebastien PonceSebastien Ponce 2 years ago (Jul 27, 2022 3:05pm UTC)

Merge details

  • Changes merged into with 270e1a33.
  • Deleted the source branch.

Pipeline #4288305 passed

Pipeline passed for 270e1a33 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • David Hutchcroft added 12 commits

    added 12 commits

    • 610c62a2 - Update Track_v3 to pick up directly position and direction
    • 695bfa23 - Fixed formatting
    • f4c6d148 - update track v3 for muon identification
    • 6924418d - update v3 track for muonID
    • 3cbbc04e - add more information in PrMuonPID
    • d94f84a2 - change name of PrMuonPIDs
    • 8ef353e3 - Fixed formatting
    • 47fe7b95 - change MuonPIDs namespace
    • 519afcf2 - Fixed formatting
    • 285f6a67 - Fixed formatting
    • 805d7bfb - change IsMuonLoose by IsMuon
    • 01007759 - Added a comment that VPSuperPixelBankEncoder output is not for DIGI/MDF use,...

    Compare with previous version

  • added 1 commit

    • e4b08eb2 - Removed unused VPLightCluster include from VPRetinaSPmixer

    Compare with previous version

  • David Hutchcroft changed target branch from RCv1 to master

    changed target branch from RCv1 to master

  • added RTA label

  • added 1 commit

    • 645d86e2 - Adding fractional cluster positions to VPlightCluster as well as VPChannelID...

    Compare with previous version

  • David Hutchcroft added 62 commits

    added 62 commits

    • 645d86e2...f339f4f5 - 41 commits from branch master
    • 35f6e523 - Added VELO cluster topology ID computation.
    • d0e1fd17 - Fixed formatting
    • 18c306dd - Fixed formatting
    • acd48743 - Added constants header file to simplify code reading and apply constants to relevant places
    • b04ec786 - Fixed formatting
    • 88e602cf - small format changes
    • 4d77fddd - Fixed formatting
    • 02c7d87e - change cluster ID
    • 2924b839 - Fixed formatting
    • d9e2ddfb - change sensorMask in VPChannelID
    • 99dbe183 - changes to VPChannelID
    • 015fe450 - changes to VPChannelID
    • 00ba8844 - Fixed formatting
    • f1040580 - added a second contructor to VPChannelID for VeloClusterTrackingSIMD
    • 5940afb0 - Fixed formatting
    • 0a973f5c - updated VPRetinaCluster BankVersion to account for change in cluster data format
    • 7b492326 - First implementation of TELL40 v1 cluster output and two sesnors SP banks
    • b392483e - Fixed error in a comment line
    • ae3c4223 - Added a comment that VPSuperPixelBankEncoder output is not for DIGI/MDF use,...
    • 7e193b6a - Removed unused VPLightCluster include from VPRetinaSPmixer
    • a74c9790 - Adding fractional cluster positions to VPlightCluster as well as VPChannelID...

    Compare with previous version

  • added 1 commit

    • b2e8f4fc - Removed unused #include Event/VPLightCluster.h in VPRetinaClusterCreator.cpp

    Compare with previous version

  • added 1 commit

    • ec933355 - Added cluster width in pixels to VPLightCluster and set in VPRetinaClusterDecoder

    Compare with previous version

  • David Hutchcroft added 106 commits

    added 106 commits

    • ec933355...a15547dd - 83 commits from branch master
    • e64a8110 - Added VELO cluster topology ID computation.
    • c7f946fa - Fixed formatting
    • e7d5ce01 - Fixed formatting
    • 720cbfc8 - Added constants header file to simplify code reading and apply constants to relevant places
    • 64c87b6e - Fixed formatting
    • 47d42371 - small format changes
    • 81db2aa0 - Fixed formatting
    • 9471e360 - change cluster ID
    • 84bd175d - Fixed formatting
    • 8c398416 - change sensorMask in VPChannelID
    • 62d8ddd4 - changes to VPChannelID
    • c034a496 - changes to VPChannelID
    • 04b3f83a - Fixed formatting
    • e77d98de - added a second contructor to VPChannelID for VeloClusterTrackingSIMD
    • dc5689a0 - Fixed formatting
    • dd68ce2d - updated VPRetinaCluster BankVersion to account for change in cluster data format
    • 059f9593 - First implementation of TELL40 v1 cluster output and two sesnors SP banks
    • ca706d60 - Fixed error in a comment line
    • afeaf5c1 - Added a comment that VPSuperPixelBankEncoder output is not for DIGI/MDF use,...
    • e4e5da67 - Removed unused VPLightCluster include from VPRetinaSPmixer
    • d1eba2b2 - Adding fractional cluster positions to VPlightCluster as well as VPChannelID...
    • 7e4b02ac - Removed unused #include Event/VPLightCluster.h in VPRetinaClusterCreator.cpp
    • 2a19a29d - Added cluster width in pixels to VPLightCluster and set in VPRetinaClusterDecoder

    Compare with previous version

  • added 1 commit

    • 5116ca9d - Fixed missing clusters after transform due to use of end not back_inserter

    Compare with previous version

  • Rosen Matev mentioned in issue #202

    mentioned in issue #202

  • added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading