Final changes to fully support dd4hep RICH PMTs/Panels
Requires Detector!158 (merged) Rec!2794 (merged) Panoptes!146 (merged)
@gcorti @seaso @bcouturi @bmalecki @tlin FYI
This MR is now ready to go. With it I have removed all use of detdesc objects when the stack is built for dd4hep, apart from a small set of calls that require volume intersections
- DetDesc intersectionTicks method to get the entry/exit points with the volume associated to an object
- DetDesc isInside method to check if a given point is inside a given volume.
As the reconstruction now fully uses the dd4hep geometry I am running into an issue due to the fact I only have MC samples generated with DetDesc, and as this geometry does not match the dd4hep one, the PID performance is highly degraded. Essentially, I cannot fully validate the reconstruction w.r.t. final PID performance without MC samples generated with a geometry that matches the dd4hep one. @seaso @gcorti any timeline on when samples matching the dd4hep geometry might become available ?
Note, due to some small machine-precision level changes, ref. log updates are expected.
Merge request reports
Activity
added RICH label
added RTA label
mentioned in merge request Detector!158 (merged)
added 4 commits
-
877b5bdf...0817abbf - 3 commits from branch
lhcb:master - b3f2cdee - Port 'detectionPoint' method to derived RichPD class, clean up API
-
877b5bdf...0817abbf - 3 commits from branch
added 8 commits
-
b3f2cdee...b5f36e45 - 6 commits from branch
lhcb:master - c86b8e58 - Port 'detectionPoint' method to derived RichPD class, clean up API
- f8286079 - RichDet changes to support RichDetectors
-
b3f2cdee...b5f36e45 - 6 commits from branch
added 1 commit
- 9fdeda4f - Implement 'detectionPoint' methods locally in RICH derived condition detector objects
added 1 commit
- 2242d954 - Implement 'detectionPoint' methods locally in RICH derived condition detector objects
added 2 commits
added 1 commit
- d6f5dc20 - Remove secondary storage from RichPDPanel PD lookup
mentioned in merge request Rec!2794 (merged)
added 11 commits
-
c006a811...f42541ac - 2 commits from branch
lhcb:master - ab109e53 - Port 'detectionPoint' method to derived RichPD class, clean up API
- 52d99923 - RichDet changes to support RichDetectors
- 11db6f11 - Implement 'detectionPoint' methods locally in RICH derived condition detector objects
- 7cc5ecd0 - Add some assert checks to RICH mirror finder
- bdb100e4 - Adapt to changes in RichDetector
- 2c29073d - Remove secondary storage from RichPDPanel PD lookup
- ae1b74db - RichPD: Reduce a bit text in printout
- 088a75db - Update refs for RichDetectors QM test
- bc80942f - Small cleanup to RichPDPanel
Toggle commit list-
c006a811...f42541ac - 2 commits from branch