Check that the RawBank is in Raw_location_db
With Allen!655 (merged), the Allen default sequence now requires the VPRetinaCluster RawBank to be present in the RawEvent.
The input_raw_format = 0.5 entry has been added to the Raw_location_db to include the VPRetinaCluster RawBank.
If a RawBank is not in the input_raw_format we would like to raise a "readable" error.
This should be tested with Moore!1429 (merged), Allen!803 (merged) and lhcb-datapkg/PRConfig!217 (merged).
Merge request reports
Activity
added RTA label
removed RTA label
mentioned in merge request Moore!1429 (merged)
mentioned in merge request Allen!803 (merged)
added RTA label
mentioned in issue Allen#294 (closed)
added 1 commit
- d4b408da - raise a key error if the raw bank is not in the raw event format
- [2022-03-13 19:13] Validation started with lhcb-master-mr#3958
- [2022-03-14 11:40] Validation started with lhcb-master-mr#3967
- [2022-03-15 09:37] Validation started with lhcb-master-mr#3979
Edited by Software for LHCbadded 3 commits
-
d4b408da...3b887afb - 2 commits from branch
master - ae3f3a99 - raise a key error if the raw bank is not in the raw event format
-
d4b408da...3b887afb - 2 commits from branch
added 26 commits
-
ae3f3a99...0817abbf - 25 commits from branch
master - 43abca8b - raise a key error if the raw bank is not in the raw event format
-
ae3f3a99...0817abbf - 25 commits from branch
mentioned in merge request lhcb-datapkg/PRConfig!217 (merged)
528 528 } 529 529 530 530 if bank_types: 531 locations = set(raw_bank_locations[bt] for bt in bank_types) 531 locations = set() 532 try: 533 for bt in bank_types: 534 locations.add(raw_bank_locations[bt]) 535 except: 536 raise KeyError("The", bt, 537 "RawBank is missing from raw_event_format", 538 raw_event_format) -
Given that
Raw_location_dbwill have to be removed, I would prefer to have a default instead of an exception.In fact !3449 (merged) already implements that, so let's close this MR.
@@ -528,7 +528,9 @@ def default_raw_event(bank_types=[], } if bank_types: - locations = set(raw_bank_locations[bt] for bt in bank_types) + locations = set( + raw_bank_locations.get(bt, ("DAQ/RawEvent", )) + for bt in bank_types) else: locations = set(raw_bank_locations.values())Edited by Rosen Matev
mentioned in issue Moore#411 (closed)