obsolete calo code cleanup

Removing old run1/2 calo code. Usage not appropriate anymore with latest changes.

Related to Rec!2871 (merged) and Moore!1526 (merged).

And issue Rec#319

added Calo PID RTA labels

mentioned in merge request Rec!2871 (merged)

mentioned in merge request Moore!1526 (merged)

changed the description

marked this merge request as ready

mentioned in issue Moore#426 (closed)

assigned to @mfontana

@mveghel would you like to change anything or should I run a ci-test?

/ci-test Rec!2871 (merged) Moore!1526 (merged)

added ci-test-triggered label

• [2022-05-04 10:19] Validation started with lhcb-master-mr#4347
• [2022-05-06 11:45] Validation started with lhcb-master-mr#4359

approved this merge request

added 1 commit

• 6297722c - slight further cleanup

Compare with previous version

added 1 commit

• b520ab94 - small fix

Compare with previous version

resolved all threads

/ci-test Rec!2871 (merged) Moore!1526 (merged)

• [2022-05-15 11:13] Validation started with lhcb-master-mr#4439
• [2022-05-17 00:08] Validation started with lhcb-head#3262
• [2022-05-17 10:01] Validation started with lhcb-head#3263
• [2022-05-18 00:10] Validation started with lhcb-head#3264
• [2022-05-19 00:14] Validation started with lhcb-head#3265

mentioned in issue Moore#432 (closed)

assigned to @cagapopo and unassigned @mfontana

added lhcb-head label

mentioned in commit lhcb-nightlies/LHCb@50f4e402

mentioned in merge request !3582 (closed)

resolved all threads

resolved all threads

The RefBot pipeline failed!

• [2022-05-19 13:16] Validation started with lhcb-master-mr#4484
• [2022-05-20 00:16] Validation started with lhcb-head#3266

The RefBot pipeline failed!

mentioned in commit Moore@df5ff7d8

The RefBot pipeline created the following reference update MRs: Moore!1572 (merged)

Click this to see encountered General warnings

Failed or unfinished build of Geant4 on x86_64_v2-centos7-clang12-opt!

Click this to see encountered Alignment warnings

Alignment/x86_64_v2-centos7-clang12-opt: Test Humboldt.iterator-vp-halves-modules contains nonzero exit code and/or warnings!
Alignment/x86_64_v2-centos7-clang12-opt: Test without ref failed: Humboldt.iterator-vp-halves-modules!

Click this to see encountered Moore warnings

Moore/x86_64_v2-centos7-gcc11-opt: Test RecoConf.hlt2_plot_calo_resolution_gamma was not run because of failed dependencies and is possibly missing a reference update!
Moore/x86_64_v2-centos7-gcc11-opt: Test RecoConf.hlt2_reco_baseline_multi_threaded was not run because of failed dependencies and is possibly missing a reference update!
Moore/x86_64_v2-centos7-gcc11-opt: Test without ref failed: Hlt1Conf.dump_for_standalone_allen!
Moore/x86_64_v2-centos7-gcc11-dbg: Test RecoConf.hlt2_plot_calo_resolution_gamma was not run because of failed dependencies and is possibly missing a reference update!
Moore/x86_64_v2-centos7-gcc11-dbg: Test RecoConf.hlt2_reco_baseline_multi_threaded was not run because of failed dependencies and is possibly missing a reference update!
Moore/x86_64_v2-centos7-gcc11-dbg: Test without ref failed: Hlt1Conf.dump_for_standalone_allen!
Moore/x86_64_v2-centos7-clang12-opt: Test RecoConf.hlt2_plot_calo_resolution_gamma was not run because of failed dependencies and is possibly missing a reference update!
Moore/x86_64_v2-centos7-clang12-opt: Test RecoConf.hlt2_reco_baseline_multi_threaded was not run because of failed dependencies and is possibly missing a reference update!
Moore/x86_64_v2-centos7-clang12-opt: Test without ref failed: Hlt1Conf.dump_for_standalone_allen!
Moore/x86_64_v3-centos7-gcc11-opt+g: Test RecoConf.hlt2_plot_calo_resolution_gamma was not run because of failed dependencies and is possibly missing a reference update!
Moore/x86_64_v3-centos7-gcc11-opt+g: Test RecoConf.hlt2_reco_baseline_multi_threaded was not run because of failed dependencies and is possibly missing a reference update!
Moore/x86_64_v3-centos7-gcc11-opt+g: Test without ref failed: Hlt1Conf.dump_for_standalone_allen!
Moore: Different test results for Hlt/RecoConf/tests/refs/hlt2_protoparticles_baseline.ref on platforms ['x86_64_v2-centos7-gcc11-opt', 'x86_64_v2-centos7-gcc11-dbg', 'x86_64_v2-centos7-clang12-opt']
Moore: Comparing x86_64_v2-centos7-gcc11-opt to:
Moore:	 x86_64_v2-centos7-gcc11-dbg differs by:
Moore:	 Differences in Output Diff:
Moore:	x86_64_v2-centos7-gcc11-opt:
CombDLLe                 = -0.130083
CombDLLe                 = -0.668683
CombDLLe                 = -0.780693
CombDLLe                 = -1.20423
CombDLLe                 = -1.51255
CombDLLe                 = -11.7965
CombDLLe                 = -2.23307
CombDLLe                 = -2.36907
CombDLLe                 = -2.39448
CombDLLe                 = -2.61276
CombDLLe                 = -2.77704
CombDLLe                 = -2.92955
CombDLLe                 = -3.40439
CombDLLe                 = -3...
Moore:	x86_64_v2-centos7-gcc11-dbg:
CombDLLe                 = -0.130079
CombDLLe                 = -0.668686
CombDLLe                 = -0.780687
CombDLLe                 = -1.20422
CombDLLe                 = -1.51257
CombDLLe                 = -11.7964
CombDLLe                 = -2.23308
CombDLLe                 = -2.36908
CombDLLe                 = -2.39447
CombDLLe                 = -2.61275
CombDLLe                 = -2.77705
CombDLLe                 = -2.92956
CombDLLe                 = -3.40438
CombDLLe                 = -3...
Moore:	 x86_64_v2-centos7-clang12-opt differs by:
Moore:	 Differences in Output Diff:
Moore:	x86_64_v2-centos7-gcc11-opt:
CombDLLe                 = -0.130083
CombDLLe                 = -0.668683
CombDLLe                 = -0.780693
CombDLLe                 = -1.20423
CombDLLe                 = -1.51255
CombDLLe                 = -11.7965
CombDLLe                 = -2.23307
CombDLLe                 = -2.36907
CombDLLe                 = -2.39448
CombDLLe                 = -2.61276
CombDLLe                 = -2.77704
CombDLLe                 = -2.92955
CombDLLe                 = -3.40439
CombDLLe                 = -3...
Moore:	x86_64_v2-centos7-clang12-opt:
CombDLLe                 = -0.130079
CombDLLe                 = -0.668686
CombDLLe                 = -0.780687
CombDLLe                 = -1.20422
CombDLLe                 = -1.51257
CombDLLe                 = -11.7964
CombDLLe                 = -2.23308
CombDLLe                 = -2.36908
CombDLLe                 = -2.39447
CombDLLe                 = -2.61275
CombDLLe                 = -2.77705
CombDLLe                 = -2.92956
CombDLLe                 = -3.40438
CombDLLe                 = -3...

mentioned in merge request Moore!1572 (merged)

resolved all threads

merged

mentioned in commit 84dd13db

mentioned in commit Moore@d7bc2122

mentioned in commit Moore@f56e60fd

mentioned in issue Moore#436 (closed)