Skip to content
Snippets Groups Projects

fix(UTDAQ): out of range access into m_bank

Merged Christoph Hasse requested to merge chasse_ut_bugfix into master
All threads resolved!

should close #229 (closed)

RecoConf.hlt1_reco_baseline_UTTELL40_with_mcchecking passes locally without crash.

But there are some open questions here for @xuyuan or anyone else familiar with the UTDAQ.

It would also be nice if a bit more documentation could be added to the code, otherwise the bit shifting and offset calculations a hard to understand.

Merge request reports

Merge request pipeline #4052401 passed

Merge request pipeline passed for e02e4b40

Merged by Sebastien PonceSebastien Ponce 2 years ago (Jun 4, 2022 4:11pm UTC)

Loading

Pipeline #4057047 passed

Pipeline passed for 31bd511d on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added RTA label

  • Christoph Hasse added 3 commits

    added 3 commits

    Compare with previous version

  • Christoph Hasse resolved all threads

    resolved all threads

  • Author Contributor

    @rmatev I've had a chat with @xuyuan, and he explained a few things to me. Thanks again @xuyuan :pray: !
    I know am back to believing that this is indeed the correct fix :thumbsup:
    So this is ready for testing

  • Sebastien Ponce resolved all threads

    resolved all threads

  • Sebastien Ponce approved this merge request

    approved this merge request

  • Sebastien Ponce mentioned in commit 31bd511d

    mentioned in commit 31bd511d

  • Please register or sign in to reply
    Loading